Math.sign and Math.trunc #2943
Merged
Math.sign and Math.trunc #2943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerobika
requested changes
Jul 4, 2019
orkvi
force-pushed
the
sign_trunc
branch
2 times, most recently
from
1f26f2b to
98e2fd4
Compare
dbatyai
requested changes
Jul 4, 2019
|
|
||
| if (ecma_number_is_negative (arg)) | ||
| { | ||
| if (ecma_number_is_zero (arg)) |
Member
There was a problem hiding this comment.
Would it be possible to merge the positive and negative is_zero checks and return with arg? Or even merge it into the is_nan check.
orkvi
force-pushed
the
sign_trunc
branch
5 times, most recently
from
973bc36 to
d5efae9
Compare
rerobika
requested changes
Jul 5, 2019
dbatyai
requested changes
Jul 8, 2019
rerobika
requested changes
Jul 10, 2019
JerryScript-DCO-1.0-Signed-off-by: Örkényi Virág orkvi@inf.u-szeged.hu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Virag Orkenyi orkvi@inf.u-szeged.hu