Allow modal to grow when inner width exceeds container width #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trim21
added a commit
to trim21/flood
that referenced
this pull request
Dec 20, 2023
…esec#597) Co-authored-by: Trim21 <trim21.me@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several issues are related to the inner width of the modal exceeding the fixed width of the container, this fix is a straight-forward fix that accounts for the various modals and allows the modal to grow if necessary.
I've briefly tested this manually by opening all modals in a non-English setup with longer translation strings and none of the modals were particularly wide as a result of this change.
Related Issue
Fixes #216
Fixes #232
Screenshots
before
after
Types of changes