Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile modal overflow #713

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Conversation

gillesdemey
Copy link
Contributor

@gillesdemey gillesdemey commented Dec 19, 2023

The modal was overflowing on mobile viewports following changes in #597

Description

This PR unsets the min-width for mobile viewports.

Related Issue

Fixes #711

Screenshots

Screenshot 2023-12-19 at 22 45 31

Types of changes

  • Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
  • New feature (non-breaking change which adds functionality - semver MINOR)
  • Bug fix (non-breaking change which fixes an issue - semver PATCH)

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5acf61b) 73.13% compared to head (06500ed) 73.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #713   +/-   ##
=======================================
  Coverage   73.13%   73.13%           
=======================================
  Files          62       62           
  Lines       11375    11375           
  Branches      959      963    +4     
=======================================
  Hits         8319     8319           
  Misses       3042     3042           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

causes issues with some modal content with unbound width
@trim21
Copy link
Collaborator

trim21 commented Dec 20, 2023

thanks

@trim21 trim21 merged commit 20a672a into jesec:master Dec 20, 2023
12 checks passed
@gillesdemey gillesdemey deleted the fix/mobile-modal branch December 20, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal bigger than screen on mobile
2 participants