chore: make weak-napi optional (#8869)

jestjs · Aug 22, 2019 · 16f7385 · 16f7385
1 parent 93555aa
commit 16f7385
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 4 deletions.
diff --git a/packages/jest-leak-detector/package.json b/packages/jest-leak-detector/package.json
@@ -11,11 +11,11 @@
   "types": "build/index.d.ts",
   "dependencies": {
     "jest-get-type": "^24.9.0",
-    "pretty-format": "^24.9.0",
-    "weak-napi": "^1.0.3"
+    "pretty-format": "^24.9.0"
   },
   "devDependencies": {
-    "@types/weak-napi": "^1.0.0"
+    "@types/weak-napi": "^1.0.0",
+    "weak-napi": "^1.0.3"
   },
   "engines": {
     "node": ">= 8"

diff --git a/packages/jest-leak-detector/src/index.ts b/packages/jest-leak-detector/src/index.ts
@@ -7,7 +7,6 @@
 
 import {setFlagsFromString} from 'v8';
 import {runInNewContext} from 'vm';
-import weak = require('weak-napi');
 import prettyFormat = require('pretty-format');
 import {isPrimitive} from 'jest-get-type';
 
@@ -24,6 +23,22 @@ export default class {
       );
     }
 
+    let weak: typeof import('weak-napi');
+
+    try {
+      // eslint-disable-next-line import/no-extraneous-dependencies
+      weak = require('weak-napi');
+    } catch (err) {
+      if (!err || err.code !== 'MODULE_NOT_FOUND') {
+        throw err;
+      }
+
+      throw new Error(
+        'The leaking detection mechanism requires the "weak-napi" package to be installed and work. ' +
+          'Please install it as a dependency on your main project',
+      );
+    }
+
     weak(value as object, () => (this._isReferenceBeingHeld = false));
     this._isReferenceBeingHeld = true;