Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make weak-napi optional #8869

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Aug 22, 2019

Summary

Discovered we still need this when upgrading to 25 at work.

$ docker run --interactive --tty --rm node:lts-alpine yarn add weak-napi
$ docker run --interactive --tty --rm node:lts-alpine sh -c "apk add --no-cache python && yarn add weak-napi"

You need to install quite a bit of stuff

This is essentially #5252 again

Test plan

Dunno...

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thought it was already optional, same as weak

@SimenB
Copy link
Member Author

SimenB commented Aug 22, 2019

I thought it wasn't needed with napi - I was wrong 😅

#8686 (comment)

@thymikee
Copy link
Collaborator

Still a little less code to ship with Jest by default! :D

@SimenB SimenB merged commit 16f7385 into jestjs:master Aug 22, 2019
@SimenB SimenB deleted the weak-napi-optional branch August 22, 2019 14:17
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@b8a4a85). Click here to learn what that means.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8869   +/-   ##
=========================================
  Coverage          ?   63.81%           
=========================================
  Files             ?      275           
  Lines             ?    11588           
  Branches          ?     2841           
=========================================
  Hits              ?     7395           
  Misses            ?     3566           
  Partials          ?      627
Impacted Files Coverage Δ
packages/jest-leak-detector/src/index.ts 83.33% <40%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8a4a85...2b71d2f. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants