Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest-resolve does not resolve dependencies correctly #5228

Closed
nickpape opened this issue Jan 4, 2018 · 4 comments
Closed

Jest-resolve does not resolve dependencies correctly #5228

nickpape opened this issue Jan 4, 2018 · 4 comments

Comments

@nickpape
Copy link

nickpape commented Jan 4, 2018

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

By default, when Node.js loads a module from a path that is symbolically linked to a different on-disk location, Node.js will dereference the link and use the actual on-disk "real path" of the module as both an identifier and as a root path to locate other dependency modules. In most cases, this default behavior is acceptable. However, when using symbolically linked peer dependencies, as illustrated in the example below, the default behavior causes an exception to be thrown if moduleA attempts to require moduleB as a peer dependency:

Jest-resolve does not do this, it acts as if the --preserve-symlinks flag was always on.

What is the expected behavior?

Jest-resolve should not preserve symlinks unless the flag is present.

@tipng
Copy link

tipng commented Apr 16, 2018

Related to #5852 ?

@SimenB
Copy link
Member

SimenB commented Apr 16, 2018

@nickpape-msft this is closed by #5085, isn't it?

@octogonz
Copy link

Yes, we can close this issue. It was fixed in Jest 22.4.3.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants