Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jest to the latest version 🚀 #173

Closed
wants to merge 1 commit into from

Conversation

greenkeeper[bot]
Copy link

@greenkeeper greenkeeper bot commented Dec 18, 2017

Version 22.0.0 of jest was just published.

Dependency jest
Current Version 21.2.1
Type devDependency

The version 22.0.0 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of jest.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

nlepage
nlepage previously approved these changes Dec 18, 2017
@nlepage nlepage dismissed their stale review December 18, 2017 14:02

Build failed

greenkeeper bot added a commit that referenced this pull request Dec 18, 2017
@greenkeeper
Copy link
Author

greenkeeper bot commented Dec 18, 2017

Version 22.0.1 just got published.

Update to this version instead 🚀

@nlepage nlepage self-assigned this Dec 19, 2017
@nlepage nlepage added this to the Future milestone Dec 19, 2017
@nlepage
Copy link
Member

nlepage commented Dec 19, 2017

Jest's new version introduces a bug in all of immutadot-lodash's tests :

    TypeError: Cannot read property 'isNaturalInteger' of undefined

      88 |    * @since 1.0.0
      89 |    */
    > 90 |   var isIndex = exports.isIndex = _lang.isNaturalInteger;
      91 | 
      92 |   /**
      93 |    * Tests whether <code>arg</code> is a valid slice index, that is an integer or <code>undefined</code>.
      
      at packages/immutadot/path/utils.js:90:43
      at Object.defineProperty.value (packages/immutadot/path/utils.js:5:7)
      at packages/immutadot/path/utils.js:13:5
      at packages/immutadot/path/utils.js:1:269
      at Object.<anonymous> (packages/immutadot/path/utils.js:1:445)
      at packages/immutadot/path/apply.js:1:330
      at Object.<anonymous> (packages/immutadot/path/apply.js:1:538)
      at packages/immutadot/core/convert.js:1:275
      at Object.<anonymous> (packages/immutadot/core/convert.js:1:402)

greenkeeper bot added a commit that referenced this pull request Dec 19, 2017
@greenkeeper
Copy link
Author

greenkeeper bot commented Dec 19, 2017

Version 22.0.2 just got published.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request Dec 19, 2017
@greenkeeper
Copy link
Author

greenkeeper bot commented Dec 19, 2017

Version 22.0.3 just got published.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request Dec 22, 2017
@greenkeeper
Copy link
Author

greenkeeper bot commented Dec 22, 2017

Version 22.0.4 just got published.

Update to this version instead 🚀

@nlepage nlepage force-pushed the greenkeeper/jest-22.0.0 branch 2 times, most recently from a45e5af to 17f89e2 Compare January 7, 2018 16:19
@nlepage
Copy link
Member

nlepage commented Jan 7, 2018

jestjs/jest#5228 may be related...

@nlepage
Copy link
Member

nlepage commented Jan 7, 2018

Error has changed :

    TypeError: (0 , _symbol2.default) is not a function

      27 |   }
      28 | 
    > 29 |   var allProps = exports.allProps = (0, _symbol2.default)('allProps');
      30 |   var index = exports.index = (0, _symbol2.default)('index');
      31 |   var list = exports.list = (0, _symbol2.default)('list');
      32 |   var prop = exports.prop = (0, _symbol2.default)('prop');
      
      at ../immutadot/path/consts.js:29:60
      at Object.defineProperty.value (../immutadot/path/consts.js:5:473)
      at ../immutadot/path/consts.js:13:5
      at ../immutadot/path/consts.js:5:91
      at Object.<anonymous> (../immutadot/path/consts.js:5:250)
      at ../immutadot/path/apply.js:5:627
      at Object.<anonymous> (../immutadot/path/apply.js:5:970)
      at ../immutadot/core/convert.js:1:275
      at Object.<anonymous> (../immutadot/core/convert.js:1:402)

@nlepage
Copy link
Member

nlepage commented Jan 7, 2018

requires from 'babel-runtime' seem to return undefined

greenkeeper bot added a commit that referenced this pull request Jan 10, 2018
@greenkeeper
Copy link
Author

greenkeeper bot commented Jan 10, 2018

Version 22.0.5 just got published.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request Jan 11, 2018
@greenkeeper
Copy link
Author

greenkeeper bot commented Jan 11, 2018

Version 22.0.6 just got published.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request Jan 15, 2018
@greenkeeper
Copy link
Author

greenkeeper bot commented Jan 15, 2018

Version 22.1.0 just got published.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request Jan 15, 2018
@greenkeeper
Copy link
Author

greenkeeper bot commented Jan 15, 2018

Version 22.1.1 just got published.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request Jan 17, 2018
@greenkeeper
Copy link
Author

greenkeeper bot commented Jan 17, 2018

Version 22.1.2 just got published.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request Jan 18, 2018
@greenkeeper
Copy link
Author

greenkeeper bot commented Jan 18, 2018

Version 22.1.3 just got published.

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request Jan 19, 2018
@greenkeeper
Copy link
Author

greenkeeper bot commented Jan 19, 2018

Version 22.1.4 just got published.

Update to this version instead 🚀

@nlepage
Copy link
Member

nlepage commented Feb 23, 2018

A potential fix has been merged in jest's master : jestjs/jest#5085

@frinyvonnick
Copy link
Contributor

So we need to wait 22.4.3

@nlepage
Copy link
Member

nlepage commented May 28, 2018

Jest 23.0.1 has been released and this is still broken.
Also tested with 22.4.4 which doesn't work either.

@nlepage
Copy link
Member

nlepage commented May 28, 2018

I made a minimal project reproducing the problem nlepage/jest-issue
I'm going to open an issue at jest

@nlepage
Copy link
Member

nlepage commented May 28, 2018

jestjs/jest#6331

@nlepage nlepage closed this Dec 4, 2018
@nlepage nlepage deleted the greenkeeper/jest-22.0.0 branch December 4, 2018 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants