chore(jest-runtime): runtime.unstable_importModule should not return Promise<void>
#12009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chentsulin
commented
Oct 28, 2021
| @@ -622,7 +622,7 @@ export default class Runtime { | |||
| async unstable_importModule( | |||
| from: Config.Path, | |||
| moduleName?: string, | |||
| ): Promise<void> { | |||
| ): Promise<VMModule | void> { | |||
There was a problem hiding this comment.
Oops! Module '"vm"' has no exported member 'Module'.
Maybe we should define it as any or unknown. Resolving void-only here is kind of misleading.
|
This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days. |
SimenB
changed the title
runtime.unstable_importModule should not return Promise<void>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
linkAndEvaluateModule(...)method returnsPromise<VMModule | void>, sounstable_importModule(...)should returns the same type.Test plan
No. Just a simple type modification.