Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jest-runtime): runtime.unstable_importModule should not return Promise<void> #12009

Merged
merged 1 commit into from
Oct 29, 2022
Merged

chore(jest-runtime): runtime.unstable_importModule should not return Promise<void> #12009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/jest-runtime/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ export default class Runtime {
async unstable_importModule(
from: Config.Path,
moduleName?: string,
): Promise<void> {
): Promise<VMModule | void> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Module '"vm"' has no exported member 'Module'.

Maybe we should define it as any or unknown. Resolving void-only here is kind of misleading.

invariant(
runtimeSupportsVmModules,
'You need to run with a version of node that supports ES Modules in the VM API. See https://jestjs.io/docs/ecmascript-modules',
Expand Down