chore: fix some type errors in tests #13360
Conversation
| 'beforeAll', | ||
| 'afterEach', | ||
| 'afterAll', | ||
| ] as Array<Circus.HookType>)('%s hooks error throwing', fn => { |
There was a problem hiding this comment.
No magic with as const? (By the way, I guess this could might be good candidate for satisfies.)
| ] as Array<Circus.HookType>)('%s hooks error throwing', fn => { | |
| ] as const)('%s hooks error throwing', fn => { |
There was a problem hiding this comment.
as const doesn't really work - then it's always hard coded to the first value
There was a problem hiding this comment.
probably an issue with jest-each's types, but I haven't dug into it
There was a problem hiding this comment.
Just checked. Interesting... I will check what is going on.
There was a problem hiding this comment.
Yep. Types are buggy and test is broken too.
Here list is [1, 2, 3]. That’s why it looks like just first value is picked up. Add second arg and second value will be there. In reality there is no second arg ;D Ups.. I will fix. Good to catch it!
packages/jest-fake-timers/src/__tests__/legacyFakeTimers.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Mrazauskas <tom@mrazauskas.de>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
I was bored on my flight home, so went over a random assortment of tests and fixed some type errors.
Ignore whitespace for this one: https://github.com/facebook/jest/pull/13360/files?w=1
Test plan
Green CI