chore: fix types of few expect tests
#13361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
changed the title
expect testsexpect tests
mrazauskas
commented
Oct 2, 2022
| @@ -224,13 +229,16 @@ test('ObjectContaining matches prototype properties', () => { | |||
| function Foo() {} | |||
| Foo.prototype = prototypeObject; | |||
| Foo.prototype.constructor = Foo; | |||
| obj = new Foo(); | |||
| obj = new (Foo as any)(); | |||
There was a problem hiding this comment.
Here TS complains about implicit any.
Comment on lines
+254
to
+255
| objectContaining({}).asymmetricMatch(null), | ||
| objectContaining({}).asymmetricMatch(undefined), |
There was a problem hiding this comment.
Added those simply for completeness.
| [{first: objectNotContaining({second: {}})}, {first: {second: {}}}], | ||
| [{}, {foo: undefined}], | ||
| ] as const | ||
| ).forEach(([sample, received]) => { |
There was a problem hiding this comment.
Was considering to use test.each, but it was hard to invent a title for each case. Without unique titles it did not look good. So perhaps forEach is fine in this file?
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Few more
expecttest with fixed types. Looks like there is no overlap with #13360. Just wanted to push these before diving intoeachtypes (;Test plan
Green CI.