feat: explicitly mention that test is failing because done() is not being called
#13847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
reviewed
Jan 31, 2023
packages/jest-circus/src/utils.ts
Outdated
| `Exceeded timeout of ${formatTime(timeout)} for a ${ | ||
| isHook ? 'hook' : 'test' | ||
| }${ | ||
| takesDoneCallback && ' while waiting for done to be called' |
There was a problem hiding this comment.
Perhaps? Not 100% sure how to make it more clear what "done" is?
Suggested change
| takesDoneCallback && ' while waiting for done to be called' | |
| takesDoneCallback && ' while waiting for `done()` to be called' |
SimenB
reviewed
Jan 31, 2023
packages/jest-circus/src/utils.ts
Outdated
| @@ -195,7 +201,7 @@ export const callAsyncCircusFn = ( | |||
|
|
|||
| return new Promise<void>((resolve, reject) => { | |||
| timeoutID = setTimeout( | |||
| () => reject(_makeTimeoutMessage(timeout, isHook)), | |||
| () => reject(_makeTimeoutMessage(timeout, isHook, takesDoneCallback(fn))), | |||
There was a problem hiding this comment.
extract takesDoneCallback(fn) - no need to call it twice
e2e/__tests__/timeouts.test.ts
Outdated
| const {stderr, exitCode} = runJest(DIR, ['-w=1', '--ci=false']); | ||
| const {rest, summary} = extractSummary(stderr); | ||
| expect(rest).toMatch( | ||
| /(jest\.setTimeout|jasmine\.DEFAULT_TIMEOUT_INTERVAL|Exceeded timeout\.while waiting for done to be called)/, |
There was a problem hiding this comment.
does jasmine have the same message? I can't find it grepping for it
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #13844
Summary
If a test fails because
done()is not called it's now specified in the error message.Example of new message:
Exceeded timeout of 5000 ms for a test while waiting for done to be called.