-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: explicitly mention that test is failing because done()
is not being called
#13847
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
399f8cc
feat: explicitly mention that test is failing because done() is not b…
lpizzinidev 6887488
added changelog entry
lpizzinidev eb85b63
fixed error message, extracted method call, and changed test expected…
lpizzinidev e0fd5f8
merged main branch
lpizzinidev b7c95d8
updated changelog entry
lpizzinidev b68595b
removed build message
lpizzinidev 0ffb3f7
fix lint
lpizzinidev 45a5d49
Update CHANGELOG.md
SimenB 7bcbaf6
Merge branch 'main' into gh-13844
SimenB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -170,9 +170,15 @@ export const describeBlockHasTests = ( | |||||
child => child.type === 'test' || describeBlockHasTests(child), | ||||||
); | ||||||
|
||||||
const _makeTimeoutMessage = (timeout: number, isHook: boolean) => | ||||||
const _makeTimeoutMessage = ( | ||||||
timeout: number, | ||||||
isHook: boolean, | ||||||
takesDoneCallback: boolean, | ||||||
) => | ||||||
`Exceeded timeout of ${formatTime(timeout)} for a ${ | ||||||
isHook ? 'hook' : 'test' | ||||||
}${ | ||||||
takesDoneCallback && ' while waiting for done to be called' | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps? Not 100% sure how to make it more clear what "done" is?
Suggested change
|
||||||
}.\nUse jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test.`; | ||||||
|
||||||
// Global values can be overwritten by mocks or tests. We'll capture | ||||||
|
@@ -195,7 +201,7 @@ export const callAsyncCircusFn = ( | |||||
|
||||||
return new Promise<void>((resolve, reject) => { | ||||||
timeoutID = setTimeout( | ||||||
() => reject(_makeTimeoutMessage(timeout, isHook)), | ||||||
() => reject(_makeTimeoutMessage(timeout, isHook, takesDoneCallback(fn))), | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. extract |
||||||
timeout, | ||||||
); | ||||||
|
||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does jasmine have the same message? I can't find it grepping for it