Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Array matching #15091

Closed
wants to merge 3 commits into from
Closed

Fix Array matching #15091

wants to merge 3 commits into from

Conversation

popeeyy
Copy link

@popeeyy popeeyy commented May 27, 2024

Fixes matching type Array for arrays created in a new context.

Summary

Fixes #15025
Jest does not correctly match arrays created in different contexts. This causes it to incorrectly match arrays from HTTP requests made by native fetch, failing tests when they should be passing.

Test plan

Added a unit test to asymmetricMatchers for arrays created in a new context.

Before:
image

After:
image

Fixes matching type Array for arrays created in a new context.
Copy link

linux-foundation-easycla bot commented May 27, 2024

CLA Not Signed

Copy link

netlify bot commented May 27, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c4e5710
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/665500a724c924000872565b
😎 Deploy Preview https://deploy-preview-15091--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@SimenB
Copy link
Member

SimenB commented May 28, 2024

Oh, can you sign the CLA?

@SimenB SimenB enabled auto-merge (squash) May 28, 2024 08:04
@popeeyy
Copy link
Author

popeeyy commented May 28, 2024

Oh, can you sign the CLA?

No.

@SimenB SimenB disabled auto-merge May 28, 2024 17:17
@SimenB
Copy link
Member

SimenB commented May 28, 2024

That's unfortunate, I don't think we'll be able to merge the PR in that case 🤔 https://github.com/jestjs/jest/blob/b7ae0b85e981eae0e373d98ab2ae8fe497d90027/CONTRIBUTING.md#contributor-license-agreement-cla

In order to accept your pull request, we need you to submit a CLA.

@popeeyy
Copy link
Author

popeeyy commented May 28, 2024

That's unfortunate, I don't think we'll be able to merge the PR in that case 🤔 https://github.com/jestjs/jest/blob/b7ae0b85e981eae0e373d98ab2ae8fe497d90027/CONTRIBUTING.md#contributor-license-agreement-cla

In order to accept your pull request, we need you to submit a CLA.

That is quite unfortunate, but I will not be sharing my full name, address, and all the other information you should not share with random organizations to contribute a few lines of code. Hopefully someone else willing to give this information away will be able to fix this issue!

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Native fetch Arrays Incorrectly Matched
2 participants