You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes matching type Array for arrays created in a new context.
Summary
Fixes#15025
Jest does not correctly match arrays created in different contexts. This causes it to incorrectly match arrays from HTTP requests made by native fetch, failing tests when they should be passing.
Test plan
Added a unit test to asymmetricMatchers for arrays created in a new context.
In order to accept your pull request, we need you to submit a CLA.
That is quite unfortunate, but I will not be sharing my full name, address, and all the other information you should not share with random organizations to contribute a few lines of code. Hopefully someone else willing to give this information away will be able to fix this issue!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes matching type Array for arrays created in a new context.
Summary
Fixes #15025
Jest does not correctly match arrays created in different contexts. This causes it to incorrectly match arrays from HTTP requests made by native fetch, failing tests when they should be passing.
Test plan
Added a unit test to asymmetricMatchers for arrays created in a new context.
Before:
After:
