Add additional globals #4949
Add additional globals #4949
Conversation
| @@ -13,10 +13,26 @@ import type {Global} from 'types/Global'; | |||
| import createProcesObject from './create_process_object'; | |||
| import deepCyclicCopy from './deep_cyclic_copy'; | |||
|
|
|||
| const DTRACE = [ | |||
There was a problem hiding this comment.
is there any module where this list is maintained? Or can we fish it out from the running global?
There was a problem hiding this comment.
Yes, we can do something like Object.keys(global).filter(dtrace => dtrace.startsWith('DTRACE_')) to get it.
| export default function(globalObject: Global, globals: ConfigGlobals) { | ||
| globalObject.process = createProcesObject(); | ||
|
|
||
| // Forward some APIs. | ||
| DTRACE.forEach(dtrace => { | ||
| globalObject['DTRACE_' + dtrace] = function() { |
There was a problem hiding this comment.
can you use ...args and arrow functions instead? arguments is bad.
There was a problem hiding this comment.
I need a proper function so that this can be captured. Using ...args sounds unnecessary to me, since no processing as Array is needed.
There was a problem hiding this comment.
You are right about this but ...args should be faster than arguments at this time.
Codecov Report
@@ Coverage Diff @@
## master #4949 +/- ##
==========================================
- Coverage 60.31% 60.29% -0.03%
==========================================
Files 198 198
Lines 6600 6598 -2
Branches 4 4
==========================================
- Hits 3981 3978 -3
- Misses 2619 2620 +1
Continue to review full report at Codecov.
|
| globalObject.Buffer = global.Buffer; | ||
| globalObject.setImmediate = global.setImmediate; | ||
| globalObject.clearImmediate = global.clearImmediate; | ||
|
|
||
| Object.assign(global, deepCyclicCopy(globals)); | ||
| return Object.assign(globalObject, deepCyclicCopy(globals)); |
There was a problem hiding this comment.
😅 This convinced me to add a test, even if the module appears to be simple.
| }; | ||
| }); | ||
|
|
||
| // Forward some others (this breaks the sandbox but for now it's OK). |
There was a problem hiding this comment.
I don't presume anyone still remembers this diff, but if you do, I'd love to hear your thoughts on #11204.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This adds
DTRACE_globals to the fakeglobalobject. This is required tonet.Socketdo call these methods).Methods are wrapped in another file so if people modifies them (e.g. by adding a static property) they will not prevent garbage collection.