Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional globals #4949

Merged
merged 1 commit into from
Nov 24, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions packages/jest-util/src/__tests__/install_common_globals.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
/**
* Copyright (c) 2017-present, Facebook, Inc. All rights reserved.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

let installCommonGlobals;
let fake;

beforeEach(() => {
fake = jest.fn();
global.DTRACE_NET_SERVER_CONNECTION = fake;

installCommonGlobals = require('../install_common_globals').default;
});

it('returns the passed object', () => {
const myGlobal = {};

expect(installCommonGlobals(myGlobal, {})).toBe(myGlobal);
});

it('turns a V8 global object into a Node global object', () => {
const myGlobal = installCommonGlobals({}, {});

expect(myGlobal.process).toBeDefined();
expect(myGlobal.DTRACE_NET_SERVER_CONNECTION).toBeDefined();

expect(myGlobal.DTRACE_NET_SERVER_CONNECTION).not.toBe(fake);
myGlobal.DTRACE_NET_SERVER_CONNECTION();
expect(fake.mock.calls.length).toBe(1);
});
12 changes: 11 additions & 1 deletion packages/jest-util/src/install_common_globals.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,23 @@ import type {Global} from 'types/Global';
import createProcesObject from './create_process_object';
import deepCyclicCopy from './deep_cyclic_copy';

const DTRACE = Object.keys(global).filter(key => key.startsWith('DTRACE'));

export default function(globalObject: Global, globals: ConfigGlobals) {
globalObject.process = createProcesObject();

// Forward some APIs.
DTRACE.forEach(dtrace => {
globalObject[dtrace] = function(...args) {
return global[dtrace].apply(this, args);
};
});

// Forward some others (this breaks the sandbox but for now it's OK).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't presume anyone still remembers this diff, but if you do, I'd love to hear your thoughts on #11204.

globalObject.Buffer = global.Buffer;
globalObject.setImmediate = global.setImmediate;
globalObject.clearImmediate = global.clearImmediate;

Object.assign(global, deepCyclicCopy(globals));
// $FlowFixMe: assigning an object.
return Object.assign(globalObject, deepCyclicCopy(globals));
}