Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nothing works as it should with 10+ medium releases, any more #133

Open
1 of 2 tasks
jesus2099 opened this issue Dec 7, 2015 · 3 comments
Open
1 of 2 tasks

Nothing works as it should with 10+ medium releases, any more #133

jesus2099 opened this issue Dec 7, 2015 · 3 comments
Assignees
@jesus2099
Labels
major mb_COLLECTION-HIGHLIGHTER server change
Milestone
2021

Comments

@jesus2099
Copy link
Owner

jesus2099 commented Dec 7, 2015 •
edited
Loading

On this 12×CD compilation, recordings are not scanned upon expanding and the dynamic updater wouldn’t work correctly if all mediums would not have been expanded first.

The (not that) quick but (absolutely) dirty fix

  • No more highlighted recording in 10+ medium releases
    • Watch DOMNodeInserted for highlighting after page load 463183e
  • Dynamic updater doesn’t see (10+ un‐expanded medium) recordings any more

The long term fix (well, after some testing… quick and dirty might be partly better)
@jesus2099 jesus2099 added this to the 2015 milestone Dec 7, 2015
This was referenced Dec 7, 2015
Open
Closed
@jesus2099
Copy link
Owner Author

#119 idea dropped because of monstrous performance loss.
Sometimes quick and dirty is not that bad.

@jesus2099 jesus2099 modified the milestones: 2015, 2016 Dec 25, 2015
@jesus2099
Copy link
Owner Author

Similar to #38 (which is for INLINE STUFF).

@jesus2099 jesus2099 modified the milestones: 2016 (late), 2017 (Ⅵ) Jun 28, 2016
@jesus2099 jesus2099 mentioned this issue Jul 10, 2016
Closed
@jesus2099 jesus2099 modified the milestones: 2017, 2018, 2019, 2019* Feb 10, 2017
@jesus2099 jesus2099 modified the milestones: 2019, 2020 Feb 1, 2019
@jesus2099 jesus2099 removed this from the 2020 milestone Jul 2, 2019
jesus2099 referenced this issue Aug 23, 2019
@jesus2099
FIX #450: Dynamic updater broken (reported by @cheezmo)
b951ac5 
Adapt to MBS change since the introduction of shared collections

- Adapt Add/Remove from `my_collection` to `collection_collaborator`
- Adapt ON/OFF from `h2.collections + ul.links` to `h2.collections + h3 + ul.links` or simply `h2.collections ~ ul.links`

Reference:

- https://tickets.metabrainz.org/browse/MBS-9428
- https://github.com/metabrainz/musicbrainz-server/pull/1061/files#diff-253ffc57335b105cd39f97120050de3c
@jesus2099 jesus2099 mentioned this issue Jun 29, 2021
Closed
2 tasks
jesus2099 added a commit that referenced this issue Jul 31, 2021
@jesus2099
Highlight stuff that appears at any time! #133 #598 #606
463183e
@jesus2099 jesus2099 mentioned this issue Jul 31, 2021
Closed
2 tasks
@jesus2099 jesus2099 pinned this issue Aug 16, 2021
@jesus2099 jesus2099 modified the milestones: 2022, 2021 Aug 21, 2021
@jesus2099
Copy link
Owner Author

Blocked by #64.

@jesus2099 jesus2099 unpinned this issue Aug 23, 2021
@jesus2099 jesus2099 removed the blocked label Dec 27, 2021
jesus2099 added a commit that referenced this issue Dec 31, 2021
@jesus2099
Code layout
f054ccb 
Trying to understand the script before #64 #133 #174 changes
@jesus2099 jesus2099 self-assigned this Dec 31, 2021
jesus2099 added a commit that referenced this issue Jan 3, 2022
@jesus2099
Super fast collection load web service #174
c5709f6 
Still lacks new:

- loadMissingRecordingWorks
- Dynamic Updater #64 #133
@jesus2099 jesus2099 mentioned this issue Jan 10, 2022
Merged
1 task
jesus2099 added a commit that referenced this issue Jan 23, 2022
@jesus2099
Dynamic loader action add in WS mode #64 #133 #612 #659
e617ef3 
Dynamic loader action remove, still in web page mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jesus2099 jesus2099

Labels
major mb_COLLECTION-HIGHLIGHTER server change
Projects
None yet
Milestone
2021
Development

No branches or pull requests
1 participant
@jesus2099