Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work with (big releases) tracks displayed with React (MBS-9921) #598

Closed
2 tasks done
jesus2099 opened this issue Jun 29, 2021 · 2 comments
Closed
2 tasks done

Does not work with (big releases) tracks displayed with React (MBS-9921) #598

jesus2099 opened this issue Jun 29, 2021 · 2 comments
Labels
mb_COLLECTION-HIGHLIGHTER react-hydrate new hint: custom mb-hydration event server change
Milestone
2021

Comments

@jesus2099
Copy link
Owner

jesus2099 commented Jun 29, 2021 •
edited
Loading

  • Dynamic loader no longer finds works if relationships are displayed at bottom fea68f4
    Inline relationships OK. Normal loader still find them so let's make the dynamic loader use the normal loading system!
    Or re-parse page when needed instead of (probably) relying on an object pointing to elements, since redrawn by React.
  • Highlight stuff that appears at any time 463183e

Related to
@jesus2099 jesus2099 pinned this issue Jun 29, 2021
@jesus2099
Copy link
Owner Author

In fact I found the react hydrate stuff in:

@jesus2099 jesus2099 changed the title Does not work with (big releases) tracks displayed with React (MBS-11703) Does not work with (big releases) tracks displayed with React (MBS-9921) Jun 29, 2021
jesus2099 added a commit that referenced this issue Jul 28, 2021
@jesus2099
Fix: Dynamic loader no longer finds works at bottom (#598)
fea68f4
jesus2099 added a commit that referenced this issue Jul 31, 2021
@jesus2099
Highlight stuff that appears at any time! #133 #598 #606
463183e
@jesus2099
Copy link
Owner Author

I still have to fix dynamic updater on big releases, see #133.

@jesus2099 jesus2099 unpinned this issue Jul 31, 2021
@jesus2099 jesus2099 added this to the 2021 milestone Aug 21, 2021
@jesus2099 jesus2099 mentioned this issue Jun 3, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mb_COLLECTION-HIGHLIGHTER react-hydrate new hint: custom mb-hydration event server change
Projects
None yet
Milestone
2021
Development

No branches or pull requests
1 participant
@jesus2099