[mysql plugin] use --log-error instead of 2> #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a permissions issue that can arise when running the MySQL plugin in CI.
Previous versions of the mysql plugin were creating error logs in the virtenv directory by routing stderr to a file. While this kept the error logs local, mysql would still create a log file in
/var/logs. This worked fine on user machines, but could hit permission errors in CI.This update now creates the error log using the --log-error flag. This should override any log creation in
/var, which will avoid the permissions error.How was it tested?
Tested locally, verified the service was still working and error logs were being captured