Release/0.4.8_i18n #840

oupula · 2025-09-28T09:43:30Z

add i18n support , add zh-CN language

CLAassistant · 2025-09-28T09:43:39Z

All committers have signed the CLA.

…/0.4.8_i18n

oupula · 2025-09-28T10:51:29Z

IDisposable · 2025-09-29T23:43:51Z

ui/public/locales/en.json

@@ -0,0 +1 @@
+{}


Is there a reason we don't put all the undisputed English stuff here, and the UK/US differences as overrides in their respective files? Are we actually doing fallback?

current only en-US and zh-CN , if browser detect without language file , i18n-next will auto failback to en-US
why put empty language file ,
my browser language is zh-CN , but i18next auto request zh.json & zh-CN.json language file ,
in english(US) the same , i18next request both file (en.json & en-US.json)
just without 404 error

My comment was more about the standard for example of putting all English translations in en.json and then where (for there are differences) the US and UK differences (and only the differences) in en-US.json and en-UK.json

IDisposable · 2025-09-29T23:45:11Z

ui/public/locales/zh-CN.json

@@ -0,0 +1,758 @@
+{


I personally do not feel qualified to review the Chinese (I could possibly do a reasonable job with German)... how do we get another Chinese person to chip in?

ui/src/components/ActionBar.tsx

ui/src/components/ConfirmDialog.tsx

ui/src/components/Header.tsx

ui/src/components/UsbInfoSetting.tsx

ui/src/routes/devices.$id.settings.general.reboot.tsx

IDisposable · 2025-09-30T00:04:58Z

ui/src/routes/devices.$id.settings.general.update.tsx

        <p className="mb-2 text-sm text-slate-600 dark:text-slate-300">
-          A new update is available to enhance system performance and improve
-          compatibility. We recommend updating to ensure everything runs smoothly.
+            {t('A_new_update_is_available_to_enhance_system_performance_and_improve_compatibility_We_recommend_updating_to_ensure_everything_runs_smoothly')}


We should probably shorten huge keys like this.

Yes, that's a good idea. but I can't decide which key replace with long sentences

Just if it's more that 5 or six words, maybe?

ui/src/routes/devices.$id.tsx

IDisposable · 2025-09-30T00:12:39Z

ui/vite.config.ts

 import tsconfigPaths from "vite-tsconfig-paths";
 import basicSsl from "@vitejs/plugin-basic-ssl";

 declare const process: {


Please revert this white-space/indentation-only change.

emm .. why after commit with the white-space ??

The file ends with three blank lines

…/0.4.8_i18n

IDisposable

Thanks for starting this off!

We've discussed internally and would rather use InLang.com for our localization package as it gives a much better developer-experience and quite a bit smaller at runtime. It compiles messages into JS functions, which are fully typed so you cannot easily forget replacement parameters and such.

Architecture
Comparison

We know it's tedious to do this initial pass, and really appreciate your efforts. Can you switch from i18next to inlang or would you like to resubmit after we pull it in?

IDisposable · 2025-10-01T16:30:20Z

ui/src/routes/devices.$id.settings.video.tsx

@@ -135,4 +134,4 @@
  };

  return (


Please restore this code, it's fine if it's not localized.

the two const use in image red frame area

I was talking about the developer mode stuff, which seems to using the wrong controlling value. Should be const { developerMode } = useSettingsStore();

oupula · 2025-10-02T06:25:49Z

Thanks for starting this off!

We've discussed internally and would rather use InLang.com for our localization package as it gives a much better developer-experience and quite a bit smaller at runtime. It compiles messages into JS functions, which are fully typed so you cannot easily forget replacement parameters and such.

Architecture Comparison

We know it's tedious to do this initial pass, and really appreciate your efforts. Can you switch from i18next to inlang or would you like to resubmit after we pull it in?

if you are do this work,I won't get involved.
but, please not use the machine translate
example :
extension is translate to "扩展" , will not translate to "扩大" , single word "extension" translate "扩大" is right! software extension function "extension" translate "扩展"

oupula · 2025-10-02T07:02:44Z

I am interest this project (with go , c and react native)
pikvm project run with python , I'm not interesting
I running the jetkvm in rasberrypi cm4 now .
modify some code(include jetkvm-native [ video encode , you are using the rk sdk ] && jetkvm-app source code)

IDisposable · 2025-10-02T17:27:50Z

We know it's tedious to do this initial pass, and really appreciate your efforts. Can you switch from i18next to inlang or would you like to resubmit after we pull it in?

if you are do this work,I won't get involved.

We welcome your input! I started a (draft) PR #864 with the paraglide translation stubbed out... will need to extract all the rest of the language-text once we're settled into a pattern.

please not use the machine translate example : extension is translate to "扩展" , will not translate to "扩大" , single word "extension" translate "扩大" is right! software extension function "extension" translate "扩展"

Oh, I get it. We will likely do a machine translation for a baseline, but we really want native speakers to contribute. That said, I will try to line up all your work in this PR with what we ship initially, and then welcome corrections.

adamshiervani · 2025-10-07T09:50:54Z

Closing this PR now, but @oupula feel more than welcome to edit the translation files in #864 or in dev once that it's merged. As @IDisposable said, we really want native speakers to contribute.

ym and others added 3 commits September 19, 2025 14:00

chore: bump to 0.4.8

114095a

add i18n support

6d9380f

add i18n support

9c703b4

Merge branch 'dev' into release/0.4.8_i18n

f7b273e

oupula marked this pull request as draft September 28, 2025 10:27

oupula added 2 commits September 28, 2025 18:36

add i18n support

6226d7c

Merge remote-tracking branch 'origin/release/0.4.8_i18n' into release…

f51c2a8

…/0.4.8_i18n

oupula marked this pull request as ready for review September 28, 2025 10:51

add i18n support

789dcb3

IDisposable requested changes Sep 30, 2025

View reviewed changes

oupula added 2 commits September 30, 2025 12:40

add i18n support

353b58a

Merge branch 'dev' into release/0.4.8_i18n

7f76fbe

oupula requested a review from IDisposable September 30, 2025 04:51

oupula added 2 commits September 30, 2025 13:13

add i18n support

4842418

Merge remote-tracking branch 'origin/release/0.4.8_i18n' into release…

08d15a5

…/0.4.8_i18n

IDisposable requested changes Oct 1, 2025

View reviewed changes

IDisposable reviewed Oct 1, 2025

View reviewed changes

oupula marked this pull request as draft October 2, 2025 06:46

adamshiervani closed this Oct 7, 2025

		@@ -0,0 +1 @@
		{} No newline at end of file

Release/0.4.8_i18n #840

Release/0.4.8_i18n #840

Uh oh!

Conversation

oupula commented Sep 28, 2025

Uh oh!

CLAassistant commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oupula commented Sep 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IDisposable left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oupula Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oupula commented Oct 2, 2025

Uh oh!

oupula commented Oct 2, 2025

Uh oh!

IDisposable commented Oct 2, 2025

Uh oh!

adamshiervani commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Sep 28, 2025 •

edited

Loading

oupula Oct 2, 2025 •

edited

Loading