-
Notifications
You must be signed in to change notification settings - Fork 215
Start localization with inlang paraglide-js #864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
cabdfe4
to
d81a497
Compare
f383397
to
cd9a55d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces internationalization (i18n) support to the JetKVM UI using the inlang paraglide-js localization framework. The implementation enables multilingual support with translations for 9 languages and includes a comprehensive setup for managing localized strings throughout the React frontend.
- Added inlang paraglide-js as the localization framework with configuration for 9 languages (en, da, de, es, fr, it, nb, sv, zh)
- Replaced hardcoded UI strings with localized message functions across multiple components
- Updated build configuration and TypeScript paths to support the new localization structure
Reviewed Changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
ui/vite.config.ts | Added paraglide Vite plugin configuration for localization build integration |
ui/tsconfig.json | Updated with new path aliases and compiler options for localization support |
ui/tsconfig.node.json | Simplified configuration by removing redundant options |
ui/package.json | Added inlang dependencies and updated scripts to include localization compilation |
ui/src/ components and routes | Replaced hardcoded strings with localized message functions |
ui/localization/ | Added complete localization setup with message files for 9 languages |
ui/index.html | Minor formatting and path corrections |
ui/eslint.config.cjs | Updated import resolution mapping for new path aliases |
Files not reviewed (1)
- ui/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cd9a55d
to
7ea1942
Compare
{ | ||
"$schema": "https://inlang.com/schema/project-settings", | ||
"baseLocale": "en", | ||
"sourceLanguageTag": "en", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This duplication is because the CLI is a bit behind the extension Sherlock, so both are needed. PR being submitted to the inlang project
Localize the extension popovers. Update package and fix tsconfig.json Expand development directory guide Move messages under localization
7ea1942
to
7f3f869
Compare
9aa9b44
to
985b53c
Compare
Accidentally lost the changes that @ym provided, brought them back
No description provided.