Release 1.6.1-gcm.0 #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maël Valais <mael@vls.dev>
Commands run: # From the jetstack-secure-gcm repo. cd chart/jetstack-secure-gcm/charts/ rm -rf cert-manager helm pull jetstack/cert-manager --version 1.6.0 --untar find cert-manager -type f -print0 | xargs -0 perl -i~ -pe 's/app\.kubernetes\.io\/name:(.*\")[a-z-._]+\.name(\".*)/app.kubernetes.io\/name:$1cert-manager.name$2/g' find cert-manager -type f -print0 | xargs -0 perl -i~ -nle 'print if !/^ *app:/' and then, do: git add -p and make sure not to remove any ubbagent-specific stuff. Signed-off-by: Maël Valais <mael@vls.dev>
This change is required due to the following error: Error: container has runAsNonRoot and image will run as root (pod: "cert-manager-apptest-1234, container: ubbagent) Signed-off-by: Maël Valais <mael@vls.dev>
…ests Signed-off-by: Maël Valais <mael@vls.dev>
4 tasks
|
1.4.4-gcm.0, 1.5.4-gcm.1 and 1.6.1-gcm.0 have been accepted! @wallrj Would you like to review this PR? |
wallrj
requested changes
Feb 18, 2022
maelvls
force-pushed
the
release-1.6
branch
2 times, most recently
from
178f2b9 to
0ed6462
Compare
|
I changed the references from 1.6.0 to 1.6.1. Since this branch was never merged into master, I don't think anyone has ever tried to use the Helm chart for 1.6.1-gcm.0, so I expect no breakage. We are good to go. |
Signed-off-by: Maël Valais <mael@vls.dev>
I changed all the references to 'sed -i~' (which was due to the need for compatibility between BSD sed on macOS and GNU sed on Linux) to perl, which is identical on both platforms. Signed-off-by: Maël Valais <mael@vls.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not release 1.6.0-gcm.0 since 1.6.1 was released the same day I did the GCM update. So I went directly to 1.6.1.
https://github.com/jetstack/jetstack-secure-gcm/releases/tag/untagged-46cf5afbfd97cce01433