Needless META-INF/resources and web-fragment.xml mounts #10164

gregw · 2023-07-27T14:15:27Z

Jetty version(s)
12

Enhancement Description

If you deploy the ee10-demo-async-rest
and dump the server, you see that the ResourceFactory for the context contains a META-INF/resources and META-INF/web-fragment.xml entries for every jar file, even though they do not exist.

Either we should not mount these resources if they do not exist.... or if we are caching non-existence, we should exclude them from a dump.

|     += oejur.ResourceFactoryInternals$LifeCycle@22d7b4f8{STARTED} - STARTED
|     |  +> mounts size=30
|     |     +> Mount[uri=jar:file:///home/gregw/src/jetty-12.0.x/jetty-home/target/jetty-home/lib/jakarta.servlet-api-6.0.0.jar!/,root=jar:file:///home/gregw/src/jetty-12.0.x/jetty-home/target/jetty-home/lib/jakarta.servlet-api-6.0.0.jar!/META-INF/resources]
|     |     +> Mount[uri=jar:file:///home/gregw/src/jetty-12.0.x/jetty-home/target/jetty-home/lib/jakarta.servlet-api-6.0.0.jar!/,root=jar:file:///home/gregw/src/jetty-12.0.x/jetty-home/target/jetty-home/lib/jakarta.servlet-api-6.0.0.jar!/META-INF/web-fragment.xml]
|     |     +> Mount[uri=jar:file:///home/gregw/src/jetty-12.0.x/jetty-home/target/jetty-home/lib/jakarta.servlet-api-6.0.0.jar!/,root=jar:file:///home/gregw/src/jetty-12.0.x/jetty-home/target/jetty-home/lib/jakarta.servlet-api-6.0.0.jar!/]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-alpn-client-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-alpn-client-12.0.0-SNAPSHOT.jar!/META-INF/resources]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-alpn-client-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-alpn-client-12.0.0-SNAPSHOT.jar!/META-INF/web-fragment.xml]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-alpn-client-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-alpn-client-12.0.0-SNAPSHOT.jar!/]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-client-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-client-12.0.0-SNAPSHOT.jar!/META-INF/resources]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-client-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-client-12.0.0-SNAPSHOT.jar!/META-INF/web-fragment.xml]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-client-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-client-12.0.0-SNAPSHOT.jar!/]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-ee10-demo-async-rest-jar-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-ee10-demo-async-rest-jar-12.0.0-SNAPSHOT.jar!/META-INF/resources/]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-ee10-demo-async-rest-jar-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-ee10-demo-async-rest-jar-12.0.0-SNAPSHOT.jar!/META-INF/web-fragment.xml]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-ee10-demo-async-rest-jar-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-ee10-demo-async-rest-jar-12.0.0-SNAPSHOT.jar!/]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-http-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-http-12.0.0-SNAPSHOT.jar!/META-INF/resources]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-http-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-http-12.0.0-SNAPSHOT.jar!/META-INF/web-fragment.xml]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-http-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-http-12.0.0-SNAPSHOT.jar!/]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-io-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-io-12.0.0-SNAPSHOT.jar!/META-INF/resources]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-io-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-io-12.0.0-SNAPSHOT.jar!/META-INF/web-fragment.xml]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-io-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-io-12.0.0-SNAPSHOT.jar!/]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-slf4j-impl-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-slf4j-impl-12.0.0-SNAPSHOT.jar!/META-INF/resources]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-slf4j-impl-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-slf4j-impl-12.0.0-SNAPSHOT.jar!/META-INF/web-fragment.xml]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-slf4j-impl-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-slf4j-impl-12.0.0-SNAPSHOT.jar!/]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-util-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-util-12.0.0-SNAPSHOT.jar!/META-INF/resources]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-util-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-util-12.0.0-SNAPSHOT.jar!/META-INF/web-fragment.xml]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-util-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-util-12.0.0-SNAPSHOT.jar!/]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-util-ajax-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-util-ajax-12.0.0-SNAPSHOT.jar!/META-INF/resources]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-util-ajax-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-util-ajax-12.0.0-SNAPSHOT.jar!/META-INF/web-fragment.xml]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-util-ajax-12.0.0-SNAPSHOT.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/jetty-util-ajax-12.0.0-SNAPSHOT.jar!/]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/slf4j-api-2.0.7.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/slf4j-api-2.0.7.jar!/META-INF/resources]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/slf4j-api-2.0.7.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/slf4j-api-2.0.7.jar!/META-INF/web-fragment.xml]
|     |     +> Mount[uri=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/slf4j-api-2.0.7.jar!/,root=jar:file:///tmp/jetty-0_0_0_0-8080-ee10-demo-async-rest_war-_ee10-demo-async-rest-any-18389751907668110065/webapp/WEB-INF/lib/slf4j-api-2.0.7.jar!/]
|     +- org.eclipse.jetty.util.resource.ResourceFactory$2@4b8729ff

The text was updated successfully, but these errors were encountered:

gregw · 2023-07-27T14:22:36Z

Most jar files are not going to have either META-INF/resources nor web-fragments.xml in them. It feels highly inefficient that we are mounting all these jars that will already have been opened by the class loader.

Could we use something like context.getClassLoader().getResources(String) to find all the fragments and resources without needing to mount the jar files just to check? I know it gives a horrible Enumeration of URLs, but we could at least use that as a cheap existence check before mounting the jar ourselves?

At the very very least, can't we unmount the jars that have nothing that we use so we can free the memory used to load them?

@janbartel when we scan a jar for annotations, do we use these mounted resources or does ASM do it's own thing?

janbartel · 2023-07-27T14:33:02Z

When we scan a Resource that is a jar we now use it as a Path and do a try-with-resources like this:

 try (Stream<Path> classStream = Files.walk(path))

gregw · 2023-07-27T14:53:58Z

Those Paths are probably from a ZipFS, so probably mounted.

Hmmm but we don't end up with all those classes mounted on the resource factory? So something different is happening.

Either way, we need to see if we can be more efficient here

janbartel · 2023-07-27T15:16:01Z

NB If we want to get rid of the Resources that we keep around (in the context MetaData), we need a different mechanism that remembers the ordering and exclusions of jars on the container classpath and the webapp classpath.

lorban · 2023-07-27T15:25:43Z

Actually, each jar file is only mounted once, but there is one mount object created for each Resource that is requested via ResourceFactory.newResource() to make a poor man's counter; that could be optimized to use a real counter instead so that you would only see 10 mounts in your example.

If we don't need to keep the resources around after the jars have been scanned, we should change the scope of the ResourceFactory, for instance by creating a Closeable one for the duration of the scan instead of using the one bound to WebAppContext.

gregw · 2023-07-27T15:59:02Z

I still think we should investigate if we can get resources from the classloader. Even 1 mount means that the jar is expanded into memory.

joakime · 2023-07-27T16:07:46Z

Even 1 mount means that the jar is expanded into memory.

ZipFs works via the Files.newByteChannel(zipfile, READ) mechanism (a SeekableByteChannel)
It doesn't load the entire jar in memory.
It will, however, maintain the zip/jar central directory in memory (essentially the map of named entries to their locations in the zip/jar)

gregw · 2023-07-27T16:27:04Z

So that's good....

But still I don't understand why there are entries for resources that do not exist?

lorban · 2023-07-27T16:29:29Z

That's an inefficiency of the current implementation: multiple Mount objects are created as they lack a resource counter. But they all point to a single real mount.

ResourceFactory.newResource() was called for jar:file:...x.jar!/META-INF/resources, jar:file:...x.jar!/META-INF/web-fragment.xml and jar:file:...x.jar!/ so the jar file is mounted once, 3 Mount objects are created, and once all 3 Mount instances are closed the jar gets unmounted. We could use a single Mount with a resource counter instead.

joakime · 2023-07-28T15:34:41Z

@lorban the Mount logic in HEAD seems sane.

I added the a testcase to prove this out in PR #10170 (a testcase that passes btw)

Copy/Pasted here ...

    /**
     * When mounting multiple points within the same JAR, only
     * 1 mount should be created, but have reference counts
     * tracked separately.
     */
    @Test
    public void testMountByJarName()
    {
        Path jarPath = MavenPaths.findTestResourceFile("jar-file-resource.jar");
        URI uriRoot = URI.create("jar:" + jarPath.toUri().toASCIIString() + "!/"); // root
        URI uriRez = URI.create("jar:" + jarPath.toUri().toASCIIString() + "!/rez/"); // dir
        URI uriDeep = URI.create("jar:" + jarPath.toUri().toASCIIString() + "!/rez/deep/"); // dir
        URI uriZzz = URI.create("jar:" + jarPath.toUri().toASCIIString() + "!/rez/deep/zzz"); // file

        try (ResourceFactory.Closeable resourceFactory = ResourceFactory.closeable())
        {
            Resource resRoot = resourceFactory.newResource(uriRoot);
            Resource resRez = resourceFactory.newResource(uriRez);
            Resource resDeep = resourceFactory.newResource(uriDeep);
            Resource resZzz = resourceFactory.newResource(uriZzz);

            assertThat(FileSystemPool.INSTANCE.mounts().size(), is(1));
            int mountCount = FileSystemPool.INSTANCE.getReferenceCount(uriRoot);
            assertThat(mountCount, is(4));
        }
    }

joakime · 2023-07-28T15:48:45Z

Looks like the dump is showing the tracked mounts of the ResourceFactory, not the tracked mounts of the FileSystemPool.

The naming in the dump should be cleaned up.
Perhaps "references" instead of "mounts", and only showing the URI used via ResourceFactory.newResource() in the output?

The excess entries is a different effort, I'll work on that too.

gregw · 2023-07-28T16:41:47Z

Maybe only dump "references" that exist?

joakime · 2023-07-28T18:44:20Z

Also pushed a new PR to fix the usages of Resource in the MetaInfConfiguration class.
See PR #10171

#10170) * Issue #10164 - test to prove out FSPool mount vs reference count logic * Issue #10164 - improve ResourceFactory.LifeCycle.dump behavior

Ensure JPMS and TLDs can coexist happily Better method naming per reviews Reworking MetaInfConfiguration with newer Java techniques in mind

…ution.

joakime · 2023-10-23T12:56:17Z

Work in branch https://github.com/jetty/jetty.project/compare/fix/12.0.x/metainf-overhaul will be presented as a PR for 12.0.4

joakime · 2024-01-24T14:31:58Z

Closing as completed already.

gregw added the Enhancement label Jul 27, 2023

gregw added this to Jetty 12.0.1 - FROZEN Jul 27, 2023

gregw assigned lorban Jul 27, 2023

joakime added a commit that referenced this issue Jul 28, 2023

Issue #10164 - test to prove out FSPool mount vs reference count logic

64ae9d8

joakime mentioned this issue Jul 28, 2023

Issue #10164 - test to prove out FSPool mount vs reference count logic #10170

Merged

joakime added a commit that referenced this issue Jul 28, 2023

Issue #10164 - test to prove out FSPool mount vs reference count logic

0d32d8e

joakime added a commit that referenced this issue Jul 28, 2023

Issue #10164 - improve ResourceFactory.LifeCycle.dump behavior

56bec73

joakime added a commit that referenced this issue Jul 28, 2023

Issue #10164 - improve MetaInfConfiguration use of Resource

a3e1384

This was linked to pull requests Jul 28, 2023

Issue #10164 - improve MetaInfConfiguration use of Resource objects #10171

Closed

Issue #10164 - test to prove out FSPool mount vs reference count logic #10170

Merged

joakime added a commit that referenced this issue Jul 31, 2023

Issue #10164 - test to prove out FSPool mount vs reference count logic (

4a2ebe0

#10170) * Issue #10164 - test to prove out FSPool mount vs reference count logic * Issue #10164 - improve ResourceFactory.LifeCycle.dump behavior

joakime moved this to 🏗 In progress in Jetty 12.0.1 - FROZEN Aug 3, 2023

joakime added a commit that referenced this issue Aug 3, 2023

Issue #10164 - improve MetaInfConfiguration use of Resource

26a65f8

Ensure JPMS and TLDs can coexist happily Better method naming per reviews Reworking MetaInfConfiguration with newer Java techniques in mind

joakime added this to Jetty 12.0.2 FROZEN Aug 23, 2023

joakime removed this from Jetty 12.0.1 - FROZEN Aug 23, 2023

joakime removed this from Jetty 12.0.2 FROZEN Sep 13, 2023

joakime added this to Jetty 12.0.3 Sep 13, 2023

joakime removed this from Jetty 12.0.3 Oct 11, 2023

joakime added this to Jetty 12.0.4 and Jetty 12.0.4 - FROZEN Oct 11, 2023

joakime added a commit that referenced this issue Oct 23, 2023

Fixes #10164 - Reduce mounts as a result of MetaInfConfiguration exec…

a30d0f2

…ution.

joakime mentioned this issue Oct 31, 2023

Issue #10164 - MetaInfConfiguration Overhaul #10816

Closed

joakime moved this to 🏗 In progress in Jetty 12.0.4 - FROZEN Nov 1, 2023

joakime assigned joakime and unassigned lorban Nov 1, 2023

joakime added a commit that referenced this issue Nov 1, 2023

Fixes #10164 - cleanup unused methods

6469f4e

joakime added a commit that referenced this issue Nov 1, 2023

Fixes #10164 - ensure only valid URIs are added to WebAppClassLoader

ad9e358

gregw linked a pull request Nov 13, 2023 that will close this issue

Issue #10164 - MetaInfConfiguration Overhaul #10816

Closed

joakime removed a link to a pull request Nov 29, 2023

Issue #10164 - MetaInfConfiguration Overhaul #10816

Closed

joakime removed this from Jetty 12.0.4 - FROZEN Nov 29, 2023

joakime added this to Jetty 12.0.5 - FROZEN Nov 29, 2023

joakime moved this to 🏗 In progress in Jetty 12.0.5 - FROZEN Nov 29, 2023

joakime removed this from Jetty 12.0.5 - FROZEN Dec 13, 2023

joakime added this to Jetty 12.0.6 FROZEN Dec 13, 2023

joakime closed this as completed Jan 24, 2024

github-project-automation bot moved this to ✅ Done in Jetty 12.0.6 FROZEN Jan 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Needless META-INF/resources and web-fragment.xml mounts #10164

Needless META-INF/resources and web-fragment.xml mounts #10164

gregw commented Jul 27, 2023

gregw commented Jul 27, 2023

janbartel commented Jul 27, 2023

gregw commented Jul 27, 2023

janbartel commented Jul 27, 2023

lorban commented Jul 27, 2023

gregw commented Jul 27, 2023

joakime commented Jul 27, 2023

gregw commented Jul 27, 2023

lorban commented Jul 27, 2023 •

edited

Loading

joakime commented Jul 28, 2023

joakime commented Jul 28, 2023

gregw commented Jul 28, 2023

joakime commented Jul 28, 2023

joakime commented Oct 23, 2023

joakime commented Jan 24, 2024

Needless META-INF/resources and web-fragment.xml mounts #10164

Needless META-INF/resources and web-fragment.xml mounts #10164

Comments

gregw commented Jul 27, 2023

gregw commented Jul 27, 2023

janbartel commented Jul 27, 2023

gregw commented Jul 27, 2023

janbartel commented Jul 27, 2023

lorban commented Jul 27, 2023

gregw commented Jul 27, 2023

joakime commented Jul 27, 2023

gregw commented Jul 27, 2023

lorban commented Jul 27, 2023 • edited Loading

joakime commented Jul 28, 2023

joakime commented Jul 28, 2023

gregw commented Jul 28, 2023

joakime commented Jul 28, 2023

joakime commented Oct 23, 2023

joakime commented Jan 24, 2024

lorban commented Jul 27, 2023 •

edited

Loading