Issue #10164 - test to prove out FSPool mount vs reference count logic #10170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorban
requested changes
Jul 28, 2023
| * @param fsUri the filesystem URI to fetch | ||
| * @return the reference count on that URI | ||
| */ | ||
| protected int getReferenceCount(URI fsUri) |
There was a problem hiding this comment.
I would make this method package-protected; we don't want anyone (including ourselves) to use it for anything but unit tests. And explicitly say in the javadoc something like "only used for testing".
...y-core/jetty-util/src/test/java/org/eclipse/jetty/util/resource/MountedPathResourceTest.java
Show resolved
Hide resolved
| } | ||
| finally | ||
| { | ||
| resourceFactory.stop(); |
There was a problem hiding this comment.
You should also assert mount count == 0 and getReferenceCount(uriRoot) == 0 after the resourceFactory is stopped.
lorban
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding testcase to show FSPool mount vs reference count logic as it currently stands in 12.0.x HEAD (from #10164 (comment))