-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Password defaults in jetty-ssl-context.xml should be removed #1615
Comments
Note that we want the demo keystore to work without the user needing to
edit files. Perhaps move passwords and keystore file itself to a testssl
module?
…On 14 Jun 2017 23:19, "Joakim Erdfelt" ***@***.***> wrote:
Currently the etc/jetty-ssl-context.xml
<https://github.com/eclipse/jetty.project/blob/jetty-9.4.6.v20170531/jetty-server/src/main/config/etc/jetty-ssl-context.xml>
has defaults for some of the passwords for the keystore.
There should be no password defaults.
Also, the SslContextFactory should produce meaningful errors if the
passwords are invalid/incorrect.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1615>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEUrQOd3-j1xgjZ2q3s_V-rR9EzqRwoks5sEE5jgaJpZM4N6dL->
.
|
@WalkerWatch Can you check these changes and update doco? |
@gregw From a feature standpoint this looks good and it works. If you want to go ahead and merge it, that'd be great. I will make sure it ends up documented. |
This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions. |
We now have the Leaving open issue #4228 for the documentation of this change. |
Currently the etc/jetty-ssl-context.xml has defaults for some of the passwords for the keystore.
There should be no password defaults.
Also, the SslContextFactory should produce meaningful errors if the passwords are invalid/incorrect.
The text was updated successfully, but these errors were encountered: