Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password defaults in jetty-ssl-context.xml should be removed #1615

Closed
joakime opened this issue Jun 14, 2017 · 6 comments
Closed

Password defaults in jetty-ssl-context.xml should be removed #1615

joakime opened this issue Jun 14, 2017 · 6 comments
Labels
Bug For general bugs on Jetty side Stale For auto-closed stale issues and pull requests

Comments

@joakime
Copy link
Contributor

joakime commented Jun 14, 2017

Currently the etc/jetty-ssl-context.xml has defaults for some of the passwords for the keystore.

There should be no password defaults.

Also, the SslContextFactory should produce meaningful errors if the passwords are invalid/incorrect.

@joakime joakime added the Bug For general bugs on Jetty side label Jun 14, 2017
@gregw
Copy link
Contributor

gregw commented Jun 15, 2017 via email

@gregw
Copy link
Contributor

gregw commented Jul 19, 2017

@WalkerWatch Can you check these changes and update doco?

@WalkerWatch WalkerWatch self-assigned this Jul 21, 2017
@WalkerWatch
Copy link
Contributor

WalkerWatch commented Jul 21, 2017

@gregw Sure thing. I will make sure to include as part of #1677 as well

@WalkerWatch WalkerWatch removed their assignment Jul 21, 2017
@WalkerWatch
Copy link
Contributor

WalkerWatch commented Jul 25, 2017

@gregw From a feature standpoint this looks good and it works. If you want to go ahead and merge it, that'd be great. I will make sure it ends up documented.

@stale
Copy link

stale bot commented Nov 20, 2019

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Nov 20, 2019
@lachlan-roberts
Copy link
Contributor

We now have the test-keystore module for Jetty 10 and the default passwords have been removed elsewhere.

Leaving open issue #4228 for the documentation of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side Stale For auto-closed stale issues and pull requests
Projects
None yet
Development

No branches or pull requests

4 participants