Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo keystore is no longer copied to jetty-base when enabling ssl #4228

Closed
lachlan-roberts opened this issue Oct 21, 2019 · 2 comments
Closed
Assignees

Comments

@lachlan-roberts
Copy link
Contributor

In jetty-9.4.x we copy a demo keystore file with a self signed certificate to jetty-base when ssl is enabled, this is not being done in jetty-10.0.x.

The documentation for both 9 & 10 says:

Note that the HTTPS module downloads a demo keystore file with a self signed certificate, which needs to be replaced by a Certificate Authority issued certificate for real deployment.

@lachlan-roberts
Copy link
Contributor Author

This may have been done for reasons described in #1673.

lachlan-roberts added a commit that referenced this issue Oct 21, 2019
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Oct 22, 2019
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts self-assigned this Oct 23, 2019
@lachlan-roberts
Copy link
Contributor Author

lachlan-roberts commented Oct 31, 2019

@WalkerWatch we have a test-keystore module in jetty-10 which sets up this demo keystore, this was done by the ssl module in jetty-9. We should mention this in the jetty-10 docs.

To use SSL they will now need to configure their own keystore with ssl.mod or explicitly enable the test-keystore module.

lachlan-roberts added a commit that referenced this issue Nov 6, 2019
…e.mod (#4229)


Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts changed the title demo keystore not being copied to jetty-base when enabling ssl demo keystore is no longer copied to jetty-base when enabling ssl Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants