Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Jetty 10 to use non-LEGACY Compliance Modes #3009

Closed
joakime opened this issue Oct 22, 2018 · 5 comments
Closed

Update Jetty 10 to use non-LEGACY Compliance Modes #3009

joakime opened this issue Oct 22, 2018 · 5 comments
Assignees
@joakime
Labels
Enhancement
Milestone
10.0.x

Comments

@joakime
Copy link
Contributor

joakime commented Oct 22, 2018

Historically, in Jetty 9.x we used LEGACY as the default operational mode for the various Compliance modes.

Starting in Jetty 10.x we should default to the current spec RFC.

This will impact Jetty code using ...

  • org.eclipse.jetty.http.HttpCompliance
  • org.eclipse.jetty.server.MultiPartFormDataCompliance
  • org.eclipse.jetty.http.CookieCompliance
@joakime joakime self-assigned this Oct 22, 2018
@joakime joakime mentioned this issue Oct 22, 2018
Closed
@joakime joakime added this to the 10.0.x milestone Oct 22, 2018
@joakime
Copy link
Contributor Author

joakime commented Oct 22, 2018

Proposed new default usage:

  • org.eclipse.jetty.http.HttpCompliance.RFC7230
  • org.eclipse.jetty.server.MultiPartFormDataCompliance.RFC7578
  • org.eclipse.jetty.http.CookieCompliance.RFC6265

This was referenced Oct 22, 2018
Closed
Closed
joakime added a commit that referenced this issue Oct 22, 2018
@joakime
Issue #3009 - Defaulting to non-LEGACY compliance modes
e908df9 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime mentioned this issue Oct 22, 2018
Merged
@joakime
Copy link
Contributor Author

joakime commented Oct 22, 2018

PR #3015 opened

joakime added a commit that referenced this issue Oct 22, 2018
@joakime
Issue #3009 - Defaulting to non-LEGACY compliance modes
1091b98 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Oct 22, 2018
@joakime
Issue #3009 - Fixing FCGI Test field value case difference
6882c32 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Oct 22, 2018
@joakime
Merge pull request #3015 from eclipse/jetty-10.x-issue-3009-non-LEGAC…
6b56314 
…Y-modes

Issue #3009 - Defaulting to non-LEGACY compliance modes
sbordet pushed a commit that referenced this issue Oct 23, 2018
@joakime @sbordet
Issue #3009 - Defaulting to non-LEGACY compliance modes
f1b1e2f 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
sbordet pushed a commit that referenced this issue Oct 23, 2018
@joakime @sbordet
Issue #3009 - Fixing FCGI Test field value case difference
4f83d91 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime
Copy link
Contributor Author

joakime commented Nov 5, 2018

Closing, completed in commit e908df9

@joakime joakime closed this as completed Nov 5, 2018
@smitagarg1
Copy link

smitagarg1 commented Apr 25, 2023 •
edited
Loading

API requests are failing with 403 AWS Signature Mismatch error post Jetty 10.0.12 upgrade .Setting HttpCompliance.LEGACY used to solve this error as shown below

gaul/s3proxy@2e61c38

But now it fails in Jetty 10 again
This is because the content type that we are sending "Content-Type: application/x-www-form-urlencoded; charset=utf-8" is converted in to uppercase "application/x-www-form-urlencoded; charset=UTF-8" .

What exactly should be used to resolve this error in Jetty 10 ? org.eclipse.jetty.http.HttpCompliance.RFC7230 doesn't seem to help here

@joakime joakime mentioned this issue Apr 25, 2023
Closed
@joakime
Copy link
Contributor Author

joakime commented Apr 25, 2023

@smitagarg1 I opened Issue #9674 to track this new concern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Enhancement
Projects
None yet
Milestone
10.0.x
Development

No branches or pull requests
2 participants
@joakime @smitagarg1