Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move old MultiPart parsing implementation to jetty-http #3010

Closed
joakime opened this issue Oct 22, 2018 · 2 comments
Closed

Move old MultiPart parsing implementation to jetty-http #3010

joakime opened this issue Oct 22, 2018 · 2 comments
Assignees
@joakime
Labels
Task
Milestone
10.0.x

Comments

@joakime
Copy link
Contributor

joakime commented Oct 22, 2018 •
edited
Loading

The older org.eclipse.jetty.util.MultiPartInputStreamParser should be moved to jetty-http for Jetty 10.x

The org.eclipse.jetty.server.MultiPartFormDataCompliance should also be move to jetty-http to be next to the other Compliance modes. (See Issue #3009 where this odd location was discovered)
@joakime joakime self-assigned this Oct 22, 2018
@joakime joakime added the Task label Oct 22, 2018
@joakime joakime added this to the 10.0.x milestone Oct 22, 2018
joakime added a commit that referenced this issue Oct 22, 2018
@joakime
Issue #3010 - Moving old MultiPart Parser
bb30be5 
+ Moving MultiPartInputStreamParser from jetty-util to jetty-http
+ Moving related classes ReadLineInputStream to jetty-http/internal
+ Moving related tests to jetty-http as well
+ Renaming test to have same name as implementation
joakime added a commit that referenced this issue Oct 22, 2018
@joakime
Issue #3010 - Moved MultiPartFormDataCompliance to jetty-http
2fd6f4d 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime mentioned this issue Oct 22, 2018
Merged
@joakime
Copy link
Contributor Author

joakime commented Oct 22, 2018

Opened PR #3016

joakime added a commit that referenced this issue Oct 22, 2018
@joakime
Issue #3010 - Moving old MultiPart Parser
d777146 
+ Moving MultiPartInputStreamParser from jetty-util to jetty-http/internal
+ Moving related classes ReadLineInputStream to jetty-http/internal
+ Moving related tests to jetty-http as well
+ Moved MultiPartFormDataCompliance to jetty-http
+ Renaming test to have same name as implementation

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Oct 22, 2018
@joakime
Merge pull request #3016 from eclipse/jetty-10.x-issue-3010-move-mult…
8683605 
…ipart-to-http

Issue #3010 - Move old MultiPart to jetty-http
sbordet added a commit that referenced this issue Oct 23, 2018
@sbordet
Issue #3010 - Moving old MultiPart Parser.
ee0656f 
Originally moved to an internal package, it is still used by other
modules such as jetty-server and jetty-servlets, so it needs to
be in an exported package.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet pushed a commit that referenced this issue Oct 23, 2018
@joakime @sbordet
Issue #3010 - Moving old MultiPart Parser
0bb8fb9 
+ Moving MultiPartInputStreamParser from jetty-util to jetty-http/internal
+ Moving related classes ReadLineInputStream to jetty-http/internal
+ Moving related tests to jetty-http as well
+ Moved MultiPartFormDataCompliance to jetty-http
+ Renaming test to have same name as implementation

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime
Copy link
Contributor Author

joakime commented Nov 5, 2018

Completed in jetty-10.0.x branch via commit d777146

@joakime joakime closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Task
Projects
None yet
Milestone
10.0.x
Development

No branches or pull requests
1 participant
@joakime