Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problems with jetty 10 WebSocket session customizer #3412

Closed
lachlan-roberts opened this issue Feb 28, 2019 · 2 comments
Closed

problems with jetty 10 WebSocket session customizer #3412

lachlan-roberts opened this issue Feb 28, 2019 · 2 comments

Comments

@lachlan-roberts
Copy link
Contributor

the autoFragment boolean is set on the WebSocketChannel by the FrameHandler.Customizer in the upgrade method of the ClientUpgradeRequest, however this is done after the WebSocketConnection creates the Parser, so the autoFragment in the Parser is never properly updated

there is also currently no way to give a FrameHandler.Customizer to the WebSocketClient for the jetty-api
@lachlan-roberts lachlan-roberts mentioned this issue Feb 28, 2019
Merged
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 1, 2019
@lachlan-roberts
Issue jetty#3412 - always customize WSChannel directly after creation
531ed56 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 1, 2019
@lachlan-roberts
Issue jetty#3412 - always customize WSChannel directly after creation
5ecd512 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 1, 2019
@lachlan-roberts
Issue jetty#3412 - use the setter on WebSocket Parser to set autoFrag…
ea6bfc1 
…ment

Signed-off-by: lachan-roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 1, 2019
@lachlan-roberts
Issue jetty#3412 - WSChannel delay config of idletimeout on WSConnection
d380012 
Signed-off-by: lachan-roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Mar 1, 2019
Merged
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 4, 2019
@lachlan-roberts
Issue jetty#3412 - WSChannel only sets idleTimeout on connection if n…
5f7f399 
…on null

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 5, 2019
@lachlan-roberts
Issue jetty#3412 - WSChannel only sets idleTimeout on connection if n…
69822ef 
…on null

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw added a commit that referenced this issue Mar 5, 2019
@gregw
Merge pull request #3413 from lachlan-roberts/jetty-10.0.x-3412-WebSo…
c63a578 
…cketSession-Customizer

Issue #3412 - WebSocket CoreSession Customizer
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 6, 2019
@lachlan-roberts
Issue jetty#3412 - fix WebSocketClient configuration methods
a24af7d 
WebSocketClient implements WebSocketPolicy but the methods were never
wired through to use the websocket core FrameHandler.Customizer

the WSClient now has a ConfigurationCustomizer which it uses to
configure the WebSocketCoreClient

Signed-off-by: lachan-roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 6, 2019
@lachlan-roberts
Issue jetty#3412 - fix WebSocketClient configuration methods
13f8202 
WebSocketClient implements WebSocketPolicy but the methods were never
wired through to use the websocket core FrameHandler.Customizer

the WSClient now has a ConfigurationCustomizer which it uses to
configure the WebSocketCoreClient

Signed-off-by: lachan-roberts <lachlan@webtide.com>
@joakime
Copy link
Contributor

joakime commented Mar 22, 2019

@lachlan-roberts is this completed?

@lachlan-roberts
Copy link
Contributor Author

yes, the WSChannel is now customised directly after its creation, and the WebSocketPolicy methods on WebSocketClient now configure a ConfigurationCustomizer which is given to the WSCoreClient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joakime @lachlan-roberts