Issue #3106 - implement WebSocketConnection stats #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakime
reviewed
Feb 26, 2019
...ket/websocket-core/src/main/java/org/eclipse/jetty/websocket/core/internal/FrameFlusher.java
Show resolved
Hide resolved
lachlan-roberts
force-pushed
the
jetty-10.0.x-3106-websocketConnectionStats
branch
from
2b4ff7f to
4f2b4b1
Compare
gregw
requested changes
Feb 27, 2019
...ket/websocket-core/src/main/java/org/eclipse/jetty/websocket/core/internal/FrameFlusher.java
Outdated
Show resolved
Hide resolved
...ket/websocket-core/src/main/java/org/eclipse/jetty/websocket/core/internal/FrameFlusher.java
Outdated
Show resolved
Hide resolved
...ket/websocket-core/src/main/java/org/eclipse/jetty/websocket/core/internal/FrameFlusher.java
Outdated
Show resolved
Hide resolved
gregw
approved these changes
Feb 28, 2019
|
@lachlan-roberts test is broken in CI? |
|
@gregw yes the parser is auto fragmenting the messages so now that we are counting frames instead of fin bits, I need to set autoFragment to false in the parser so that we count the correct number of frames i was having some trouble setting autofragment to false so I created another issue for that, see #3412 |
lachlan-roberts
force-pushed
the
jetty-10.0.x-3106-websocketConnectionStats
branch
from
2700096 to
fd7da67
Compare
|
waiting on the changes from #3413 |
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
force-pushed
the
jetty-10.0.x-3106-websocketConnectionStats
branch
from
fd7da67 to
1160a8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement connection stats for websockets #3106