Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PushBuilder tck test failures #4825

Closed
janbartel opened this issue Apr 29, 2020 · 0 comments · Fixed by #4829
Closed

PushBuilder tck test failures #4825

janbartel opened this issue Apr 29, 2020 · 0 comments · Fixed by #4829
Assignees
Labels
Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)

Comments

@janbartel
Copy link
Contributor

10.0.x
serverPushCookieTest:
https://github.com/eclipse-ee4j/jakartaee-tck/blob/8.0.2/src/com/sun/ts/tests/servlet/spec/serverpush/TestServlet4.java
Fails because jetty does not copy Set-Cookie headers from the response to Cookie headers on the PushBuilder

serverPushInitTest:
https://github.com/eclipse-ee4j/jakartaee-tck/blob/8.0.2/src/com/sun/ts/tests/servlet/spec/serverpush/TestServlet2.java
Fails because jetty does not copy Authorization header from the request to the PushBuilder

serverPushNegativeTest:
https://github.com/eclipse-ee4j/jakartaee-tck/blob/8.0.2/src/com/sun/ts/tests/servlet/spec/serverpush/TestServlet7.java
Fails because:

NullPointerException should be thrown if the argument of method() is null
IllegalArgumentException should be thrown if set method "" to be used for the push
IllegalArgumentException should be thrown if set method "POST" to be used for the push
IllegalArgumentException should be thrown if set method "PUT" to be used for the push
IllegalArgumentException should be thrown if set method "DELETE" to be used for the push
IllegalArgumentException should be thrown if set method "CONNECT" to be used for the push
IllegalArgumentException should be thrown if set method "OPTIONS" to be used for the push
IllegalArgumentException should be thrown if set method "TRACE" to be used for the push

@janbartel janbartel added Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc) labels Apr 29, 2020
@janbartel janbartel self-assigned this Apr 29, 2020
janbartel added a commit that referenced this issue Apr 29, 2020
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Apr 29, 2020
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Apr 29, 2020
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Apr 29, 2020
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Apr 29, 2020
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue May 1, 2020
* Issue #4825 Implement spec requirements for Request.newPushBuilder

Signed-off-by: Jan Bartel <janb@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant