Issue #4825 - Implement spec requirements for Request.newPushBuilder #4829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel
added
Specification
Signed-off-by: Jan Bartel <janb@webtide.com>
sbordet
requested changes
Apr 29, 2020
jetty-server/src/main/java/org/eclipse/jetty/server/PushBuilderImpl.java
Outdated
Show resolved
Hide resolved
| continue; | ||
| switch (header) | ||
| { | ||
| case SET_COOKIE: |
There was a problem hiding this comment.
You can easily coalesce the null-check and the switch into a single if (header == SET_COOKIE).
How about SET_COOKIE2 (I'm ok to not consider it, just raising the issue of whether we want to explicitly not consider it).
There was a problem hiding this comment.
Set-Cookie2 is an actual header from a valid spec.
https://tools.ietf.org/html/rfc2965
Signed-off-by: Jan Bartel <janb@webtide.com>
sbordet
approved these changes
Apr 30, 2020
joakime
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4825
Implement spec for javax.servlet.http.PushBuilder according to the javadoc, and as tested for by the tck.