-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable "gcloud" profile for gcloud session testing. #5568
Conversation
We need to enable gcloud session testing on CI. This would allow us to vet dependency updates for things like grpc (#5510) |
looking at it. currently this fail because |
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
a901bef
to
55e35a1
Compare
…able-gcloud-testing Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
So the exceptions reported are IOExceptions, connection refused. This is because the com.google.cloud.datastore.testing.LocalDatastoreHelper class calls this method on com.google.cloud.testing.BaseEmulatorHelper to find a free port to start the server process on:
This won't work, as we discovered in the jetty-maven-plugin integration tests. You can't ask ServerSocket to find you an available port and just use the port number, you have to use the ServerSocket returned, otherwise the os may allocate that port to another user by the time you get around to trying to connect to it. I've checked the latest available google code for the google-cloud-core jar (v 1.94.0) and this problem is still there. Can you look into how we would dockerize this test instead, as that may avoid this problem. |
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
closing in favour of #5651 5651 |
Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com