Enable gcloud testing in docker #5651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
olamy
force-pushed
the
jetty-9.4.x-enable-gcloud-testing-docker
branch
from
3239dc7 to
f08cfad
Compare
janbartel
requested changes
Nov 16, 2020
| @@ -78,6 +94,7 @@ | |||
| <artifactId>maven-surefire-plugin</artifactId> | |||
| <configuration> | |||
| <skipTests>false</skipTests> | |||
| <trimStackTrace>false</trimStackTrace> | |||
| <systemPropertyVariables> | |||
| <DATASTORE_DATASET>jetty9-work</DATASTORE_DATASET> | |||
| <DATASTORE_HOST>http://localhost:8088</DATASTORE_HOST> | |||
There was a problem hiding this comment.
I don't think lines 99-100 are needed anymore are they?
There was a problem hiding this comment.
ah yup. We will need that in the top pom :)
| @@ -25,8 +25,6 @@ | |||
| import java.util.Properties; | |||
|
|
|||
| import org.eclipse.jetty.toolchain.test.FS; | |||
| import org.eclipse.jetty.toolchain.test.jupiter.WorkDir; | |||
| import org.eclipse.jetty.toolchain.test.jupiter.WorkDirExtension; | |||
| import org.eclipse.jetty.util.IO; | |||
There was a problem hiding this comment.
Not a fan of making changes to totally unrelated code ... but as they're unused imports I guess its ok.
There was a problem hiding this comment.
This looks like changes from a merge.
There was a problem hiding this comment.
@joakime nope I was just looking at this class and removed unused imports
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
joakime
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.