Temorarily delete Clippy in CI #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like the current approach of commenting clippy issues isn't working, if someone forks a repository and triggers a pull request from there (see actions/first-interaction#10). Since the clippy output contains only messages, that are nice-to-have, but non-essential, this commit simply disables the whole action in CI. This should be looked at and fixed later on.
jfrimmel
added a commit
that referenced
this pull request
Sep 18, 2024
In contrast to the older approach (removed in #59), this simply fails the `style` CI job if there are clippy warnings or errors instead of commenting it to the pull request. This has the downside, that new lints introduced in the stable Rust compiler might break users committing new code, but at least the action is clear in such a case. The upside com- pared to the commenting approach is, that it is simple and will always work (even for new contributors). Fixes #60.
jfrimmel
added a commit
that referenced
this pull request
Sep 18, 2024
In contrast to the older approach (removed in #59), this simply fails the `style` CI job if there are clippy warnings or errors instead of commenting it to the pull request. This has the downside, that new lints introduced in the stable Rust compiler might break users committing new code, but at least the action is clear in such a case. The upside com- pared to the commenting approach is, that it is simple and will always work (even for new contributors). Fixes #60.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the current approach of commenting clippy issues isn't
working, if someone forks a repository and triggers a pull request from
there (see actions/first-interaction#10).
Since the clippy output contains only messages, that are nice-to-have,
but non-essential, this commit simply disables the whole action in CI.
This should be looked at and fixed later on.