Fix all actionable clippy lints and re-enable clippy in CI #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will silence many non-applicable lints (e.g. the lint suggesting to use the new inline formatting, which is not part of Rust 1.51).
Clippy rightfully complains, that a `.skip(0)` does not make sense and likely should have been a `.skip(1)`. This commit changes it, but it is strange, that both versions work and pass the test suite. Therefore this is a separate commit, so it could be reverted if necessary.
In contrast to the older approach (removed in #59), this simply fails the `style` CI job if there are clippy warnings or errors instead of commenting it to the pull request. This has the downside, that new lints introduced in the stable Rust compiler might break users committing new code, but at least the action is clear in such a case. The upside com- pared to the commenting approach is, that it is simple and will always work (even for new contributors). Fixes #60.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all clippy lints reported by the current stable compiler (1.81), which work on the MSRV. The non-actionable lints are suppressed by specifying the MSRV in the clippy configuration file. This way, clippy will not report lints such as the one suggesting to use the new inline formatting, which is not part of Rust 1.51). Most changes are mechanical, except for the
.skip(0)-call, which is suspicious. There is a separate commit explaining this issue.In contrast to the older approach (removed in #59), this simply fails the
styleCI job if there are clippy warnings or errors instead of commenting it to the pull request. This has the downside, that new lints introduced in the stable Rust compiler might break users committing new code, but at least the action is clear in such a case. The upside compared to the commenting approach is, that it is simple and will always work (even for new contributors).Fixes #60.