Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added try and catch to not break the app when it is problem with an url #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hugo-glez
Copy link

when some url do not respond the program breaks. With the try and catch it continues with the next url transparently, no other info is presented.

try:
copy = urlopen(urls)
except:
pass
Copy link

@4383 4383 Jul 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hugo-glez!
This instruction is useless... the continue instruction is enough

try:
copy = urlopen(urls)
except:
pass
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this instruction is useless... the continue instruction is enough

try:
copy = urlopen(urls)
except:
pass
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this instruction is useless... the continue instruction is enough

copy = urlopen(urls)
try:
copy = urlopen(urls)
except:
Copy link

@4383 4383 Jul 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I think you need to manage more properly the exceptions regarding to the raison of the exception raised by urlopen.

copy = urlopen(urls)
try:
copy = urlopen(urls)
except:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I think you need to manage more properly the exceptions regarding to the raison of the exception raised by urlopen.

copy = urlopen(urls)
try:
copy = urlopen(urls)
except:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I think you need to manage more properly the exceptions regarding to the raison of the exception raised by urlopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants