Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added try and catch to not break the app when it is problem with an url #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added try and catch to not break the app when it is problem with an url #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion badactors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@ def blue(text):


for urls in urlss:
copy = urlopen(urls)
try:
copy = urlopen(urls)
except:
Copy link

@4383 4383 Jul 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I think you need to manage more properly the exceptions regarding to the raison of the exception raised by urlopen.

pass
Copy link

@4383 4383 Jul 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hugo-glez!
This instruction is useless... the continue instruction is enough

continue
ips = []
count = 0
start = time.time()
Expand Down
6 changes: 5 additions & 1 deletion reallybadactors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ def blue(text):


for urls in urlss:
copy = urlopen(urls)
try:
copy = urlopen(urls)
except:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I think you need to manage more properly the exceptions regarding to the raison of the exception raised by urlopen.

pass
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this instruction is useless... the continue instruction is enough

continue
ips = []
count = 0
start = time.time()
Expand Down
6 changes: 5 additions & 1 deletion twostrikes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@ def blue(text):


for urls in urlss:
copy = urlopen(urls)
try:
copy = urlopen(urls)
except:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I think you need to manage more properly the exceptions regarding to the raison of the exception raised by urlopen.

pass
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this instruction is useless... the continue instruction is enough

continue
ips = []
count = 0
start = time.time()
Expand Down