Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Heroku deployment #82

Closed
1 of 2 tasks
atomfrede opened this issue Jun 8, 2020 · 4 comments · Fixed by #85
Closed
1 of 2 tasks

Support Heroku deployment #82

atomfrede opened this issue Jun 8, 2020 · 4 comments · Fixed by #85
Assignees
Labels
enhancement 💎 New feature or request

Comments

@atomfrede
Copy link
Member

atomfrede commented Jun 8, 2020

Overview of the feature request

I realized some configuration is spring specific (e.g. the build task for heroku), such that the build/deployment fails.

Motivation for or Use Case

One should be able to use mhipster heroku to deploy an application to Heroku with ease.

Related issues or PR

As I am right now on some heroku related things, I can take care of this.

  • Make the heroku sub gene blueprint aware
  • Adapt heroku files (gradle, properties) to micronaut
@atomfrede atomfrede added bug 🐞 Something isn't working enhancement 💎 New feature or request labels Jun 8, 2020
@atomfrede
Copy link
Member Author

@JasonTypesCodes Just to make sure, is the gradle build supported to work? It seems it doesn't generate a valid executable jar file.

@JasonTypesCodes
Copy link
Contributor

@atomfrede You know, I noticed that when I was adding workflows to the project and forgot to add an issue for it. I'll add one now.

@JasonTypesCodes
Copy link
Contributor

@atomfrede I'm curious why you labelled this issue as a bug?

@atomfrede
Copy link
Member Author

Good question, at first I thought it was "bug" like some missing configuration, but there are a lot of more things to do also in the main generator. But good news, maven deploy works just fine with my current changes!

@atomfrede atomfrede removed the bug 🐞 Something isn't working label Jun 8, 2020
atomfrede added a commit to atomfrede/generator-jhipster-micronaut that referenced this issue Jun 8, 2020
atomfrede added a commit to atomfrede/generator-jhipster-micronaut that referenced this issue Jun 10, 2020
@atomfrede atomfrede removed the Has PR label Jun 10, 2020
atomfrede added a commit to atomfrede/generator-jhipster-micronaut that referenced this issue Jun 11, 2020
atomfrede added a commit to atomfrede/generator-jhipster-micronaut that referenced this issue Jun 18, 2020
atomfrede added a commit to atomfrede/generator-jhipster-micronaut that referenced this issue Jun 28, 2020
atomfrede added a commit that referenced this issue Jul 14, 2020
* initial support for heroku deployment

closes #82

* correct linting for heroku generator

* correct linting for heroku generator

* add oauth properties

* correct procfile

* enforce ssl host resolving when using heroku

* fix linting errors

* update to jhipster 6.10.0

* support maven jwt heroku deployment

* fix indentation for heroku properties

* sync users from idp to local database

* correct okta setup script

* use id or access token to work with keycloak and okta

* logout redirect url is completly created on the server provider agnostic

* remove not used properties from logout response

* correct logout workflow for okta

* fix ci sample verification

* remove obsolete .yo-rc.json

* upgrade to main generator 6.10.1

* prevent always queuing of build application task

* prevent always queuing of build application task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💎 New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants