-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial support for Heroku deployment #85
initial support for Heroku deployment #85
Conversation
4271aad
to
a45bf3a
Compare
e60fddb
to
651faf9
Compare
b5574ee
to
8f6fbe2
Compare
@atomfrede I'd love to have this working for a blog post I hope to write when Micronaut 2.0 is released next week (and this blueprint shortly after). Do you have permission to add more labels so I can assign it a bug bounty? |
Let me check. We need to have a new main generator release for this and I would like to have jhipster/generator-jhipster#11712 merged so heroku has much more features. |
@mraible I can edit the labels. I will create our defined bounty labels here too. |
@atomfrede Is there anything I can do to help out with this PR? |
This basically waiting for the main generator release. Everything is working. |
@pascalgrimaud Any chance of getting a new JHipster release so we can have Heroku + Okta in the main generator? |
@mraible : just sent an email to our dev mailing list :) |
8f6fbe2
to
7d4714e
Compare
Following is tested and working:
This is the route error in the logs when using gradle
Using maven the same router logs give a 200. Creating the logout redirect urls is done completely on the server now (making the endsession endpoint provider agnostic see #45. So we may rename it). Will do some final manual tests tomorrow. Regarding the gradle problem I still have no idea why the frontend is not delivered, but thats not preventing this to be merged. |
Good news. I have modified application working fine with okta both with login/logout and user sync. Will try to push the generator code tonight and test it again. |
generators/server/templates/src/main/java/package/security/KeycloakEndSessionEndpoint.java.ejs
Outdated
Show resolved
Hide resolved
This is great @atomfrede. There is a lot of good stuff here. |
Regarding the gradle 404s on heroku I still have no clue. The jar works just fine locally. I will have a chat with the new heroku java language owner next week maybe he has an idea or hint how to further debug it. |
Somehow the builds are flaky on ci, but eventually all green here too. So from my side we could merge this after review (let's ignore the gradle app reachable on heroku for now). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have experience with Heroku @atomfrede. If you feel good about this, I think it is alright. I was going to see if we could add CI for this, but it looks like you need an active Heroku account for it
If this is a known bug we should create an issue for it right away once we merge. |
This PR adds initial support for Heroku deployment of micronaut apps. It requires #84 and depends on upcoming changes in the main generator (thats why it is in draft mode).
closes #82
waiting on jhipster/generator-jhipster#11919