-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[internal] add linked issue workflow that check closing issues samples #24190
Conversation
4402578
to
7ce85ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is to a have full generated sample check at closing (linked) issues at PRs. Like we have in check-issue
workflow.
- the action used to get linked issues prints a warning
- the action used to get linked issues uses custom html parsing
we should use an action that uses github's built-in closingIssuesReferences - issues should be converted to a matrix to check every closing issue
- should generate the sample using
jhipster from-issue
, check frontend, backend and e2e. - should add a summary check in case we want to make it a requirement to merge
You can use an unfinished branch https://github.com/mshima/generator-jhipster/tree/skip_ci-generate-sample that I am working in parallel to #24135.
3ea1aff
to
a320fdf
Compare
@SudharakaP have you seen the workflow from the branch I´ve posted? |
297d934
to
7a1c14f
Compare
11f4e64
to
bfb1cb1
Compare
@mshima : I've made some changes and I believe I've addressed all the concerns here. Take a look and let me know if there's anything missing.
I didn't use this exactly as I found it a bit hard to understand but hope my method does the job as well. Let me know if you think there's anything I am missing and I am happy to add it. 😉 |
And I've tested it with this on the current PR run;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure to remove blueprint support for security reason.
Blueprint auto install can install an arbitrary package and execute it.
24a4a6b
to
bcef48c
Compare
363eb2d
to
6425f61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will work on disable blueprint support before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix prettier.
Thanks. I've fixed prettier as well as added the |
03c4cdd
to
75ce917
Compare
@mshima : Thanks a lot for all the reviews and feedback. 🤗 |
Resolve #24183
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.