Skip to content

Commit

Permalink
data/aws/vpc/common: Drop unused (private|public)_subnet_count variables
Browse files Browse the repository at this point in the history
The final consumers were removed in c80edad (data/aws/vpc: Drop
aws_route_table data blocks, 2018-11-30, openshift#769).
  • Loading branch information
wking authored and jhixson74 committed Dec 6, 2019
1 parent 7f95487 commit 4c35560
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions data/data/aws/vpc/common.tf
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,8 @@ locals {
// The VPC ID to use to build the rest of the vpc data sources
vpc_id = aws_vpc.new_vpc.id

// When referencing the _ids arrays or data source arrays via count = , always use the *_count variable rather than taking the length of the list
private_subnet_ids = aws_subnet.private_subnet.*.id
public_subnet_ids = aws_subnet.public_subnet.*.id
private_subnet_count = local.new_az_count
public_subnet_count = local.new_az_count
private_subnet_ids = aws_subnet.private_subnet.*.id
public_subnet_ids = aws_subnet.public_subnet.*.id
}

# all data sources should be input variable-agnostic and used as canonical source for querying "state of resources" and building outputs
Expand Down

0 comments on commit 4c35560

Please sign in to comment.