data/aws/vpc: Drop aws_route_table data blocks

[wking]

These were added in f828666 (coreos/tectonic-installer#3092), and never seem to have had a consumer. Removing them should fix occasional flakes like:

level=error msg="Error: Error applying plan:\n\n1 error(s) occurred:\n\n* module.vpc.data.aws_route_table.worker[1]: data.aws_route_table.worker.1: Your query returned no results. Please change your search criteria and try again.\n\nTerraform does not automatically rollback in the face of errors.\nInstead, your Terraform state file has been partially updated with\nany resources that successfully completed. Please address the error\nabove and apply again to incrementally change your infrastructure."

I've also removed the data.aws_subnet blocks, whose last consumers were removed in f828666.

[wking]

e2e-aws:

2018/11/30 18:17:27 Container setup in pod e2e-aws completed successfully
...
E1130 18:20:56.932625     742 memcache.go:147] couldn't get resource list for apps.openshift.io/v1: the server could not find the requested resource
E1130 18:20:56.987595     742 memcache.go:147] couldn't get resource list for authorization.openshift.io/v1: the server could not find the requested resource
E1130 18:20:57.031251     742 memcache.go:147] couldn't get resource list for build.openshift.io/v1: the server could not find the requested resource
E1130 18:20:57.088350     742 memcache.go:147] couldn't get resource list for image.openshift.io/v1: the server could not find the requested resource
E1130 18:20:57.104669     742 memcache.go:147] couldn't get resource list for oauth.openshift.io/v1: the server could not find the requested resource
E1130 18:20:57.127455     742 memcache.go:147] couldn't get resource list for project.openshift.io/v1: the server could not find the requested resource
E1130 18:20:57.187285     742 memcache.go:147] couldn't get resource list for quota.openshift.io/v1: the server could not find the requested resource
E1130 18:20:57.201708     742 memcache.go:147] couldn't get resource list for route.openshift.io/v1: the server could not find the requested resource
E1130 18:20:57.227586     742 memcache.go:147] couldn't get resource list for security.openshift.io/v1: the server could not find the requested resource
E1130 18:20:57.320054     742 memcache.go:147] couldn't get resource list for user.openshift.io/v1: the server could not find the requested resource

So we got through Terraform (confirming that the lines I'm removing here are dead code) and then died in the test suite due to other flakes (the OpenShift API server?). If we want to try to push this through to reduce the data.aws_route_table.worker.1: Your query returned no results flakes, someone drop an /lgtm and I'll start banging away on /retest ;). Otherwise we can wait until the other flakes are addressed.

[crawford]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [crawford,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[crawford]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[wking]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[abhinavdahiya]

/retest

[wking]

e2e-aws:

fail [github.com/openshift/origin/test/extended/util/cli.go:668]: Dec 1 01:41:09.621: the server could not find the requested resource (post users.user.openshift.io)

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[wking]

e2e-aws:

E1201 03:36:31.459047 1 reflector.go:136] github.com/openshift/origin/pkg/router/controller/factory/factory.go:112: Failed to list *v1.Route: the server is currently unable to handle the request (get routes.route.openshift.io)

/retest

[wking]

e2e-aws:

fail [k8s.io/kubernetes/test/e2e/scheduling/resource_quota.go:129]: Expected error:
    <*errors.errorString | 0xc4200cf560>: {
        s: "timed out waiting for the condition",
    }
    timed out waiting for the condition
not to have occurred

/retest

[openshift-ci-robot]

@wking: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-libvirt	c80edad	link	/test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.