-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no_std support and CI check for embedded #6
Conversation
Looks like it's failing for a simple reason — As for CI, I'm actually going to opt just have a single check for an embedded environment, rather than check everything on that alone. This is especially important given it's a tier 2 target. Would you prefer to make these changes yourself, or would you like me to do them? It's mostly trivial replacement, but it's still a learning experience 🙂 CI can be tricky, though. |
Looks like I got a little copy/paste happy. I would love to make the changes. Thanks. |
- add std conditional for before_1_42 Condvar usage
I'm going to keep working on this. |
Ok, I think that is it. You said you wanted just a single test with the embedded target, but I just added a duplicate |
These changes are required to resolve time-rs/time#246 |
Thanks! I'll take a look at the CI bit later today; that's not a big deal. |
Superfluous CI failure, given that commit was only bumping version. Merging. |
I am pretty new to Rust and am using it for embedded. I was unable to compile this library for an embedded target even when supplying the
--no-default-features
build option as seen below:(using rustc 1.44.0-nightly (94d346360 2020-04-09))
I added a conditional
#![no_std]
in the crate root (not(std)) and also as well as in1_42.rs
where needed. In addition, I added an embedded target for the check performed with the--no-default-features
flag. It is my understanding that this is one option to ensure that the check actually fails if notno_std
. It does appear that rustc versions before 1.42 will still fail. I'm not sure what would be required to get those working.