-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#![no_std]
, embedded support
#246
Conversation
Waiting for resolution of jhpratt/standback#6 and version bump. |
Standback is my crate, FYI. Consider that done after a quick review later. The second commit is correct in functionality, but I felt it was cleaner to emit two separate flags. I'm open to being convinced, though! As with standback, I'll handle the CI side of things to avoid unnecessary duplication. |
Boy do I feel silly 😳.
As I've mentioned, I'm pretty new. I think I've seen it as in my commit more, but don't have strong feelings about it. I think for me, it doesn't hide the |
No worries! Unless you were looking at who has control on crates.io or who has committed to the repos, there's no reason for you to know. And realistically, it doesn't much matter.
For what it's worth if it's clearer to new people, that's typically what's preferred! cfg aliases certainly isn't something a beginner needs to be familiar with, either. |
Make embedded its own check, rather than part of the OS-level checking. Also remove nightly, as we already know it works on stable.
Looks like everything is working as expected. All I really did was get CI to a place I like. Thank you! |
Fixes #243
Requires jhpratt/standback#6
This should allow
time
to be used with no_std targets assuming the author of standback accepts my PR.The second commit isn't required, but (in my opinion) is a cleaner way of checking the
std
feature. It might be completely wrong.