Validation and field updates #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
birkland
force-pushed
the
require_media_of
branch
from
695fdc2 to
295ec0a
Compare
birkland
changed the title
|
2 similar comments
|
|
Ingests will no longer silently orphan media if the member_of field is empty, or malformed (i.e. a typo, pointing to a non-existant id).
birkland
force-pushed
the
require_media_of
branch
from
6f018fa to
1d6ccdb
Compare
|
bseeger
reviewed
Sep 10, 2021
|
|
Spinning this up now to give it a look. |
bseeger
approved these changes
Sep 10, 2021
There was a problem hiding this comment.
This looks good to me and works as advertised.
Worth nothing -- this ticket makes it so one can only attach Images to Collections. One cannot attach other Media Types to Collections anymore, after this goes in.
(I think this is sufficient, btw, but just wanted to get it in writing somewhere).
jaredgalanis
pushed a commit
that referenced
this pull request
Feb 15, 2022
…gs-non-writable Ensure drupal settings are writable to fix non-bootable container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
media_ofa required field. Ingests will no longer silently orphan media if themedia_offield isempty, or malformed (i.e. a typo, pointing to a non-existent id).
field_digital_publisherrequired, as per stakeholder feedback related to citationsResolves jhu-idc/iDC-general#406