Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation and field updates #208

Merged
merged 9 commits into from
Sep 10, 2021
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions codebase/config/sync/field.field.media.audio.field_media_of.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,16 @@ dependencies:
config:
- field.storage.media.field_media_of
- media.type.audio
- node.type.islandora_object
bseeger marked this conversation as resolved.
Show resolved Hide resolved
enforced:
module:
- islandora_core_feature
module:
- epp
third_party_settings:
epp:
value: ''
on_update: 1
_core:
default_config_hash: InUFyVlpxFYVY-YhhapTUcRhFN2ckUDTH37xpa3Gs2M
id: media.audio.field_media_of
Expand All @@ -16,11 +23,17 @@ entity_type: media
bundle: audio
label: 'Media of'
description: ''
required: false
required: true
translatable: false
default_value: { }
default_value_callback: ''
settings:
handler: 'default:node'
handler_settings: { }
handler_settings:
target_bundles:
islandora_object: islandora_object
sort:
field: _none
auto_create: false
auto_create_bundle: collection_object
bseeger marked this conversation as resolved.
Show resolved Hide resolved
field_type: entity_reference
17 changes: 15 additions & 2 deletions codebase/config/sync/field.field.media.document.field_media_of.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,16 @@ dependencies:
config:
- field.storage.media.field_media_of
- media.type.document
- node.type.islandora_object
enforced:
module:
- islandora_core_feature
module:
- epp
third_party_settings:
epp:
value: ''
on_update: 1
_core:
default_config_hash: hCtesdEi_L52_jy8fXeSz8iof2nR_h6KdIHwHhojtvg
id: media.document.field_media_of
Expand All @@ -16,11 +23,17 @@ entity_type: media
bundle: document
label: 'Media of'
description: ''
required: false
required: true
translatable: false
default_value: { }
default_value_callback: ''
settings:
handler: 'default:node'
handler_settings: { }
handler_settings:
target_bundles:
islandora_object: islandora_object
sort:
field: _none
auto_create: false
auto_create_bundle: ''
field_type: entity_reference
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ dependencies:
config:
- field.storage.media.field_media_of
- media.type.extracted_text
- node.type.islandora_object
module:
- epp
third_party_settings:
epp:
value: ''
on_update: 1
_core:
default_config_hash: y9R5H1jor6fE99GN9mvpbOkNiq3_xWCt-ROho5REz2U
id: media.extracted_text.field_media_of
Expand All @@ -13,15 +20,17 @@ entity_type: media
bundle: extracted_text
label: 'Media of'
description: ''
required: false
required: true
translatable: true
default_value: { }
default_value_callback: ''
settings:
handler: 'default:node'
handler_settings:
target_bundles: null
target_bundles:
islandora_object: islandora_object
sort:
field: _none
auto_create: false
auto_create_bundle: ''
field_type: entity_reference
17 changes: 15 additions & 2 deletions codebase/config/sync/field.field.media.file.field_media_of.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,16 @@ dependencies:
config:
- field.storage.media.field_media_of
- media.type.file
- node.type.islandora_object
enforced:
module:
- islandora_core_feature
module:
- epp
third_party_settings:
epp:
value: ''
on_update: 1
_core:
default_config_hash: ZoFg1xcTNbj60kVradrk0lqIv9uKpyipN6vwxdFV7nQ
id: media.file.field_media_of
Expand All @@ -16,11 +23,17 @@ entity_type: media
bundle: file
label: 'Media of'
description: ''
required: false
required: true
translatable: false
default_value: { }
default_value_callback: ''
settings:
handler: 'default:node'
handler_settings: { }
handler_settings:
target_bundles:
islandora_object: islandora_object
sort:
field: _none
auto_create: false
auto_create_bundle: ''
field_type: entity_reference
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,16 @@ dependencies:
config:
- field.storage.media.field_media_of
- media.type.fits_technical_metadata
- node.type.islandora_object
enforced:
module:
- islandora_fits
module:
- epp
third_party_settings:
epp:
value: ''
on_update: 1
_core:
default_config_hash: 8CDR4tcfysCDQ6CBinsRniQdpngQlB7dyoDF2xQTj04
id: media.fits_technical_metadata.field_media_of
Expand All @@ -16,11 +23,17 @@ entity_type: media
bundle: fits_technical_metadata
label: 'Media of'
description: ''
required: false
required: true
translatable: true
default_value: { }
default_value_callback: ''
settings:
handler: 'default:node'
handler_settings: { }
handler_settings:
target_bundles:
islandora_object: islandora_object
sort:
field: _none
auto_create: false
auto_create_bundle: ''
field_type: entity_reference
17 changes: 15 additions & 2 deletions codebase/config/sync/field.field.media.image.field_media_of.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,16 @@ dependencies:
config:
- field.storage.media.field_media_of
- media.type.image
- node.type.islandora_object
enforced:
module:
- islandora_core_feature
module:
- epp
third_party_settings:
epp:
value: ''
on_update: 1
_core:
default_config_hash: II3-g2WzFJTItCsK7PFCOchXURVgIiu6X9J4NBpEju0
id: media.image.field_media_of
Expand All @@ -16,11 +23,17 @@ entity_type: media
bundle: image
label: 'Media of'
description: ''
required: false
required: true
translatable: false
default_value: { }
default_value_callback: ''
settings:
handler: 'default:node'
handler_settings: { }
handler_settings:
target_bundles:
islandora_object: islandora_object
sort:
field: _none
auto_create: false
auto_create_bundle: ''
field_type: entity_reference
17 changes: 15 additions & 2 deletions codebase/config/sync/field.field.media.video.field_media_of.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,16 @@ dependencies:
config:
- field.storage.media.field_media_of
- media.type.video
- node.type.islandora_object
enforced:
module:
- islandora_core_feature
module:
- epp
third_party_settings:
epp:
value: ''
on_update: 1
_core:
default_config_hash: h5JQnggi4jLBpJfch-_9pxhCzQem-ZkOjnrOrHqNHHo
id: media.video.field_media_of
Expand All @@ -16,11 +23,17 @@ entity_type: media
bundle: video
label: 'Media of'
description: ''
required: false
required: true
translatable: false
default_value: { }
default_value_callback: ''
settings:
handler: 'default:node'
handler_settings: { }
handler_settings:
target_bundles:
islandora_object: islandora_object
sort:
field: _none
auto_create: false
auto_create_bundle: ''
field_type: entity_reference
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,19 @@ dependencies:
- taxonomy.vocabulary.corporate_body
- taxonomy.vocabulary.family
- taxonomy.vocabulary.person
module:
- epp
third_party_settings:
epp:
value: ''
on_update: 1
id: node.islandora_object.field_digital_publisher
field_name: field_digital_publisher
entity_type: node
bundle: islandora_object
label: 'Digital Publisher'
description: '<b>Required if known</b>. Record the agent responsible for publishing, releasing, or issuing a digital version of the resource. Please add or use terms from <a href="/admin/structure/taxonomy/manage/person/overview" target="_blank">Person</a>, <a href="/admin/structure/taxonomy/manage/corporate_body/overview" target="_blank">Corporate Body</a>, or <a href="/admin/structure/taxonomy/manage/family/overview" target="_blank">Family</a> taxonomies. If digitized by the library, please select "Johns Hopkins Sheridan Libraries" as the digital publisher.'
required: false
required: true
translatable: false
default_value: { }
default_value_callback: ''
Expand Down
4 changes: 4 additions & 0 deletions codebase/config/sync/field.storage.media.field_media_of.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,12 @@ dependencies:
module:
- islandora_core_feature
module:
- field_permissions
bseeger marked this conversation as resolved.
Show resolved Hide resolved
- media
- node
third_party_settings:
field_permissions:
permission_type: public
_core:
default_config_hash: VN6byCtafQaDCBbb4rpeh3YZPTHgir0ycHw6y-S-TYw
id: media.field_media_of
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ field_name: field_alternative_title
entity_type: node
type: language_value_pair
settings:
max_length: '500'
max_length: '5000'
is_ascii: false
case_sensitive: false
target_type: taxonomy_term
Expand Down
1 change: 1 addition & 0 deletions end-to-end/tests/admin/s3.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ test('Verify original file and derivatives are in S3', async t => {
// migrate the test objects into Drupal
await migrate(t, 'idc_ingest_taxonomy_islandora_accessterms', '../testdata/s3/access-terms.csv');
await migrate(t, 'idc_ingest_taxonomy_subject', '../testdata/s3/subject.csv');
await migrate(t, 'idc_ingest_taxonomy_corporatebody', '../testdata/s3/corporatebody.csv');
await migrate(t, migrate_new_collection, '../testdata/s3/s3-collection.csv');
await migrate(t, migrate_new_items, '../testdata/s3/s3-islandora_object.csv');
await migrate(t, migrate_media_image, '../testdata/s3/s3-file.csv', 30000);
Expand Down
2 changes: 2 additions & 0 deletions end-to-end/tests/testdata/s3/corporatebody.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
unique_id,name,primary_name,subordinate_name,date_of_meeting_or_treaty,location_of_meeting,num_of_section_or_meet,corporate_body_alt_name,relationships,date,authority,description
s3_corp_01,S3 Corporate Body,S3 Corporate Body,,,,,,,2021||2022,,<p>This is a corporate body to fulfill required metadata constraints</p>
3 changes: 2 additions & 1 deletion end-to-end/tests/testdata/s3/s3-islandora_object.csv
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
node_id,unique_id,title,abstract,access_rights,access_terms,alternative_title,collection_number,contributor,copyright,copyright_holder,creator,custodial_history,date_available,date_copyrighted,date_created,date_published,description,digital_identifier,digital_publisher,display_hints,dspace_identifier,dspace_itemid,extent,featured_item,finding_aid,genre,geoportal_link,issn,is_part_of,item_barcode,jhir_uri,language,library_catalog_link,member_of,model,oclc_number,publisher,publisher_country,resource_type,spatial_coverage,subject,table_of_contents,title_language,years
,s3_io_01,S3 Repository Item 1,,::name:Public digital access,:::accesscontrol_00,,,,::name:No Known Copyright,,,,2000-01-01,2000-01-01,2000-01-01,2000-01-01,,,,,,,,0,,,,,,,,,,:::s3-collection-01,Image,,,,::name:Dataset||::name:Image,,:::subject-01,,::name:English,2000
,s3_io_01,S3 Repository Item 1,,::name:Public digital access,:::accesscontrol_00,,,,::name:No Known Copyright,,,,2000-01-01,2000-01-01,2000-01-01,2000-01-01,,,:corporate_body::s3_corp_01,,,,,0,,,,,,,,,,:::s3-collection-01,Image,,,,::name:Dataset||::name:Image,,:::subject-01,,::name:English,2000
r
Loading