Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make old manuscript files *actually* delete #643

Merged
merged 3 commits into from
May 24, 2023

Conversation

cansavvy
Copy link
Collaborator

@cansavvy cansavvy commented May 24, 2023

Purpose/implementation Section

What changes are being implemented in this Pull Request?

Despite the rm -rf manuscript command, old files in the manuscript folder still remain (see the two 2- files in this example: https://github.com/griffithlab/CIVIC_SVI_Course/tree/main/manuscript).

What was your approach?

I think in this instance we actually needed a force push to make sure old files in the manuscript folder are not kept.

To test this, I'm adding a dummy file: manuscript/2-old-version-chapter.md. This dummy file should be deleted if the changes to render-all.yml are correct.

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023

No broken urls! 🎉
Comment updated at 2023-05-24 with changes from 706a2ba

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023

Re-rendered previews from the latest commit:

Updated at 2023-05-24 with changes from 706a2ba

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023

No spelling errors! 🎉
Comment updated at 2023-05-24 with changes from 706a2ba

@cansavvy
Copy link
Collaborator Author

I may have to test this by actually merging it. It can't find the main branch when I run the workflow from this branch.

@cansavvy
Copy link
Collaborator Author

I'm going to do a YOLO thing so I can test if this will actually work. I'm going to be bad and merge this. I think the error: src refspec main does not match any error: failed to push some refs to 'https://***@github.com/jhudsl/OTTR_Template' error is because its not being run on main when I test it.

@cansavvy cansavvy merged commit badd560 into main May 24, 2023
@cansavvy cansavvy deleted the cansavvy/manuscripts-delete branch May 24, 2023 16:35
cansavvy added a commit that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant