Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt #2 at making manuscript folder actually delete #644

Merged
merged 8 commits into from
May 24, 2023

Conversation

cansavvy
Copy link
Collaborator

Purpose/implementation Section

What changes are being implemented in this Pull Request?

#643 didn't work.

Next attempt is to commit the rm -rf manuscript/ step before we committ the new files.

Copy link
Member

@carriewright11 carriewright11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cansavvy did this "old version" work?

@cansavvy
Copy link
Collaborator Author

@cansavvy did this "old version" work?

No, this is a larger problem now with committing to main for all steps in render-all.yml. Looking into how we fix it.

@carriewright11
Copy link
Member

@cansavvy did this "old version" work?

No, this is a larger problem now with committing to main for all steps in render-all.yml. Looking into how we fix it.

oh goodness - confusing...

@carriewright11
Copy link
Member

I am happy to help more but it is hard to keep up with what you have looked at...I can meet about this tomorrow if you want.

@github-actions
Copy link
Contributor

Re-rendered previews from the latest commit:

Updated at 2023-05-24 with changes from c453766

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023

No spelling errors! 🎉
Comment updated at 2023-05-24 with changes from c453766

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023

No broken urls! 🎉
Comment updated at 2023-05-24 with changes from c453766

@cansavvy cansavvy merged commit e8e301b into main May 24, 2023
@cansavvy cansavvy deleted the cansavvy/manuscripts-delete branch May 24, 2023 19:51
@cansavvy
Copy link
Collaborator Author

I am happy to help more but it is hard to keep up with what you have looked at...I can meet about this tomorrow if you want.

I wrote this in slack but not here. A lot of the reason I thought this was failing was that my test I was using (manual workflow dispatch on the development branch) was not a good test. But when merged to main things work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants