-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt #2 at making manuscript folder actually delete #644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cansavvy did this "old version" work?
No, this is a larger problem now with committing to main for all steps in render-all.yml. Looking into how we fix it. |
oh goodness - confusing... |
I am happy to help more but it is hard to keep up with what you have looked at...I can meet about this tomorrow if you want. |
Re-rendered previews from the latest commit:
Updated at 2023-05-24 with changes from c453766 |
No spelling errors! 🎉 |
No broken urls! 🎉 |
I wrote this in slack but not here. A lot of the reason I thought this was failing was that my test I was using (manual workflow dispatch on the development branch) was not a good test. But when merged to main things work fine. |
Purpose/implementation Section
What changes are being implemented in this Pull Request?
#643 didn't work.
Next attempt is to commit the
rm -rf manuscript/
step before we committ the new files.