feat: Support events type on alerts. #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jianyuan Hi, can you please approve for workflow run? |
|
I'm not sure why the GitHub secrets are not passed into the workflow. I'll approve and merge it anyways and let the tests run on the main branch. Thanks for your contributions, @eugeniykurasov! |
jianyuan
approved these changes
Dec 9, 2022
|
Thanks for merge. |
|
@eugeniykurasov After doing some testing, it seems that the get metric alert endpoint that is nested under the "projects" resource does not return the event types. We will need to switch to the one that is nested under the "organisations" resource:
I will fix this shortly. |
This was referenced Dec 12, 2022
|
@jianyuan thanks. I tested few alerts type (which I have access). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.